langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #19987] fix: search query and refine the logic #29283

New Issue
Closed
opened 2026-02-21 20:45:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:14 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/19987

State: closed
Merged: Yes

Summary

This pull request refactors the Annotation component in web/app/components/app/annotation/index.tsx to improve state management, streamline logic, and enhance readability. Key changes include replacing inline destructuring with a props object, consolidating state declarations, optimizing useEffect dependencies, and simplifying function implementations.

Refactoring and State Management Improvements:

  • Replaced inline destructuring in the Annotation component's function signature with a props object for better readability and consistency. ([web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125))
  • Consolidated multiple useState declarations for component states, such as isChatApp, isShowAnnotationFullModal, and currPage, into a more organized structure. ([web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125))
  • Optimized the useEffect dependencies by adding missing dependencies and suppressing unnecessary ESLint warnings. ([web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125))

Logic Simplifications:

  • Simplified the ensureJobCompleted function by removing redundant variables and directly using a while (true) loop. ([web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125))
  • Streamlined the handleAdd, handleRemove, and handleSave functions by reducing redundant object spreading and improving notification calls. ([web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125))

UI and Loading State Enhancements:

  • Improved the conditional rendering of the List component by addressing nested conditional logic and suppressing a SonarJS warning. ([web/app/components/app/annotation/index.tsxR186](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2R186))

Fix https://github.com/langgenius/dify/issues/19907

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/19987 **State:** closed **Merged:** Yes --- # Summary This pull request refactors the `Annotation` component in `web/app/components/app/annotation/index.tsx` to improve state management, streamline logic, and enhance readability. Key changes include replacing inline destructuring with a `props` object, consolidating state declarations, optimizing `useEffect` dependencies, and simplifying function implementations. ### Refactoring and State Management Improvements: * Replaced inline destructuring in the `Annotation` component's function signature with a `props` object for better readability and consistency. (`[web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125)`) * Consolidated multiple `useState` declarations for component states, such as `isChatApp`, `isShowAnnotationFullModal`, and `currPage`, into a more organized structure. (`[web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125)`) * Optimized the `useEffect` dependencies by adding missing dependencies and suppressing unnecessary ESLint warnings. (`[web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125)`) ### Logic Simplifications: * Simplified the `ensureJobCompleted` function by removing redundant variables and directly using a `while (true)` loop. (`[web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125)`) * Streamlined the `handleAdd`, `handleRemove`, and `handleSave` functions by reducing redundant object spreading and improving notification calls. (`[web/app/components/app/annotation/index.tsxL34-R125](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2L34-R125)`) ### UI and Loading State Enhancements: * Improved the conditional rendering of the `List` component by addressing nested conditional logic and suppressing a SonarJS warning. (`[web/app/components/app/annotation/index.tsxR186](diffhunk://#diff-b77f97c9249680c3da387352a09c7d063f729b05094a64c592a41d2f1dda70e2R186)`) Fix https://github.com/langgenius/dify/issues/19907 > [!Tip] > Close issue syntax: `Fixes #<issue number>` or `Resolves #<issue number>`, see [documentation](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for more details. # Screenshots | Before | After | |--------|-------| | ... | ... | # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:14 -05:00
yindo closed this issue 2026-02-21 20:45:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?