langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20004] fix create_tracing_app_config error (#19884) #29289

New Issue
Closed
opened 2026-02-21 20:45:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:15 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20004

State: closed
Merged: Yes

Summary

Fixes #19884

This pull request addresses an issue where trace was not functioning as expected due to improper handling of the tracing_provider configuration in the app_ops_trace_config. Previously, when tracing_provider was either missing or not present in the provider_config_map, the function logic could continue inappropriately, leading to unintended behavior or runtime errors.

Key Changes:
• Added proper None checks and key existence validations for tracing_provider.
• Introduced defensive programming logic to return early if the provider is invalid or not configured.

This fix ensures that tracing will only proceed if a valid provider is explicitly configured and recognized.

Code Summary:

return None

tracing_provider = app_ops_trace_config.get("tracing_provider")
if tracing_provider is None:
return None
try:
provider_config_map[tracing_provider]
except KeyError:
return None

decrypt_token

Motivation:

Trace configuration should fail gracefully and silently when misconfigured, rather than causing errors or silently failing without indication.

Dependencies:

No new dependencies introduced.

**Original Pull Request:** https://github.com/langgenius/dify/pull/20004 **State:** closed **Merged:** Yes --- Summary Fixes #19884 This pull request addresses an issue where trace was not functioning as expected due to improper handling of the tracing_provider configuration in the app_ops_trace_config. Previously, when tracing_provider was either missing or not present in the provider_config_map, the function logic could continue inappropriately, leading to unintended behavior or runtime errors. Key Changes: • Added proper None checks and key existence validations for tracing_provider. • Introduced defensive programming logic to return early if the provider is invalid or not configured. This fix ensures that tracing will only proceed if a valid provider is explicitly configured and recognized. Code Summary: return None tracing_provider = app_ops_trace_config.get("tracing_provider") if tracing_provider is None: return None try: provider_config_map[tracing_provider] except KeyError: return None # decrypt_token Motivation: Trace configuration should fail gracefully and silently when misconfigured, rather than causing errors or silently failing without indication. Dependencies: No new dependencies introduced.
yindo added the pull-request label 2026-02-21 20:45:15 -05:00
yindo closed this issue 2026-02-21 20:45:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?