langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-24 04:25:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20025] fix: uninitialized variable error on empty knowledge retrieval(agent) #29295

New Issue
Closed
opened 2026-02-21 20:45:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:16 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20025

State: closed
Merged: Yes

Summary

Address the UnboundLocalError caused by accessing uninitialized retrieval_resource_list during empty knowledge base queries in Agent mode. This fix ensures robustness against empty retrieval scenarios.

🧾 Problem Analysis
When knowledge base queries return no results, the retrieval_resource_list variable was conditionally initialized inside a branch, leading to runtime errors:
tool invoke error: cannot access local variable 'retrieval_resource_list' where it is not associated with a value

🔧 Fix Implementation
Scope Adjustment : Move retrieval_resource_list initialization to the top of the function scope

📦 Impact Assessment
Scope : Only adjusts variable initialization logic, without involving changes to functional logic
Compatibility : Fully backward-compatible with existing workflows
Benefit : Eliminates crash risk during edge-case scenarios while maintaining normal functionality

Resolves issues similar to #14691

Screenshots

Before
image

After
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20025 **State:** closed **Merged:** Yes --- # Summary Address the UnboundLocalError caused by accessing uninitialized retrieval_resource_list during empty knowledge base queries in Agent mode. This fix ensures robustness against empty retrieval scenarios. 🧾 Problem Analysis When knowledge base queries return no results, the retrieval_resource_list variable was conditionally initialized inside a branch, leading to runtime errors: `tool invoke error: cannot access local variable 'retrieval_resource_list' where it is not associated with a value ` 🔧 Fix Implementation Scope Adjustment : Move` retrieval_resource_list` initialization to the top of the function scope 📦 Impact Assessment Scope : Only adjusts variable initialization logic, without involving changes to functional logic Compatibility : Fully backward-compatible with existing workflows Benefit : Eliminates crash risk during edge-case scenarios while maintaining normal functionality Resolves issues similar to #14691 # Screenshots Before ![image](https://github.com/user-attachments/assets/5d6dec25-66b4-4545-b88a-fee823ac9d97) After ![image](https://github.com/user-attachments/assets/6262de46-bed0-4f88-9c80-8853e50654aa) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:16 -05:00
yindo closed this issue 2026-02-21 20:45:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?