langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-25 13:36:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20072] chore: Update S3StorageConfig to match boto3 type hints #29309

New Issue
Closed
opened 2026-02-21 20:45:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20072

State: closed
Merged: Yes

Summary

A separate PR (#20063) failed due to the introduction of missing boto3 type stubs. These stubs surfaced a potential type mismatch between S3StorageConfig.S3_ADDRESS_STYLE and what boto3 expects in the following line:

https://github.com/langgenius/dify/blob/d31235ca134ca6b9d52f969a2309ef898d7fe773/api/extensions/storage/aws_s3_storage.py#L35

extensions/storage/aws_s3_storage.py:35: error: Incompatible types (expression has type "str", TypedDict item "addressing_style" has type "Literal['auto', 'virtual', 'path']")  [typeddict-item]

This PR includes a proposed fix for the mypy error, but it’s only one possible solution. Feel free to modify or approach the fix differently if needed.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20072 **State:** closed **Merged:** Yes --- # Summary A separate PR ([#20063](https://github.com/langgenius/dify/pull/20063)) failed due to the introduction of missing `boto3` type stubs. These stubs surfaced a potential type mismatch between `S3StorageConfig.S3_ADDRESS_STYLE` and what `boto3` expects in the following line: [https://github.com/langgenius/dify/blob/d31235ca134ca6b9d52f969a2309ef898d7fe773/api/extensions/storage/aws\_s3\_storage.py#L35](https://github.com/langgenius/dify/blob/d31235ca134ca6b9d52f969a2309ef898d7fe773/api/extensions/storage/aws_s3_storage.py#L35) ``` extensions/storage/aws_s3_storage.py:35: error: Incompatible types (expression has type "str", TypedDict item "addressing_style" has type "Literal['auto', 'virtual', 'path']") [typeddict-item] ``` This PR includes a proposed fix for the `mypy` error, but it’s only one possible solution. Feel free to modify or approach the fix differently if needed. # Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:18 -05:00
yindo closed this issue 2026-02-21 20:45:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?