langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20113] fix #17085: streaming response issue with nested condition nodes #29318

New Issue
Open
opened 2026-02-21 20:45:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20113

State: open
Merged: No

Summary

Fix https://github.com/langgenius/dify/issues/17085

Due to nested condition nodes, reachable_nodes may not be fully fetched, which can lead to LLM nodes being removed from self.rest_node_ids.

To address this, I updated the logic to add the currently fetched reachable_nodes back into self.rest_node_ids, ensuring that accidentally removed nodes can be recovered. Additionally, I changed self.rest_node_ids from a list to a set to improve lookup efficiency.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20113 **State:** open **Merged:** No --- # Summary Fix https://github.com/langgenius/dify/issues/17085 Due to nested condition nodes, `reachable_nodes` may not be fully fetched, which can lead to LLM nodes being removed from `self.rest_node_ids`. To address this, I updated the logic to add the currently fetched `reachable_nodes` back into `self.rest_node_ids`, ensuring that accidentally removed nodes can be recovered. Additionally, I changed `self.rest_node_ids` from a list to a set to improve lookup efficiency. # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?