langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20188] Bug in Doc Extractor when encounters with SJIS(Japanese Symbols) #29331

New Issue
Closed
opened 2026-02-21 20:45:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:20 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20188

State: closed
Merged: No

Summary

When SJIS(Japanese Symbols) containing document is input to the Doc Extractor, it returns an unexpected result.

Below is the code snippet where the bug happens:
return file_content.decode("utf-8", "ignore")
The "ignore" parameter skips to handle SJIS properly leading the result being non-readable content.

This changes only focus on handling Japanese language but considering the growth in numbers of clients uisng Dify in Japan, this bug-fix is critical.

Screenshots

Used Sample:
記事サンプル.txt

Used Flow:
image

BEFORE
image

AFTER
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20188 **State:** closed **Merged:** No --- # Summary When SJIS(Japanese Symbols) containing document is input to the Doc Extractor, it returns an unexpected result. Below is the code snippet where the bug happens: return file_content.decode("utf-8", "ignore") The "ignore" parameter skips to handle SJIS properly leading the result being non-readable content. This changes only focus on handling Japanese language but considering the growth in numbers of clients uisng Dify in Japan, this bug-fix is critical. # Screenshots Used Sample: [記事サンプル.txt](https://github.com/user-attachments/files/20446412/default.txt) Used Flow: ![image](https://github.com/user-attachments/assets/c2f1a8d8-7d3f-4b42-9e99-77234ca6d731) **BEFORE** ![image](https://github.com/user-attachments/assets/60e651fc-fb7e-4f5d-85a0-8f97b68dfcf5) **AFTER** ![image](https://github.com/user-attachments/assets/84b02193-3968-458c-bc21-80f05481796b) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request. - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:20 -05:00
yindo closed this issue 2026-02-21 20:45:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?