langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20532] fix(housekeeping): exclude files that are used as app icons or avatar images from being removed #29413

New Issue
Closed
opened 2026-02-21 20:45:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20532

State: closed
Merged: Yes

Summary

This PR updates the housekeeping commands to prevent them from removing images that are in use as app icons or avatar images, by additionally gathering files on following columns in tables:

  • avatar column in accounts table
  • icon column in apps and sites tables

Closes #20531

Screenshots

Before: The command removes app icon and avator images.

> docker exec -it docker-api-1 flask clear-orphaned-file-records
...
Starting orphaned file records cleanup.
- Listing message_files records where message_id doesn't exist in messages table
No orphaned message_files records found. There is nothing to delete.
- Listing file records in table upload_files
- Listing file records in table tool_files
Found 2 files in tables.
- Listing file ids in column upload_file_id in table message_files
- Listing file-id-like strings in column data_source_info in table documents
- Listing file-id-like strings in column content in table document_segments
- Listing file-id-like strings in column answer in table messages
- Listing file-id-like strings in column inputs in table workflow_node_executions
- Listing file-id-like strings in column process_data in table workflow_node_executions
- Listing file-id-like strings in column outputs in table workflow_node_executions
- Listing file-id-like strings in column introduction in table conversations
- Listing file-id-like strings in column system_instruction in table conversations
- Listing file-id-like JSON string in column inputs in table messages
- Listing file-id-like JSON string in column message in table messages
Found 0 file ids in tables.
Found 2 orphaned file records.     👈👈👈
- orphaned file id: b28c6aac-cacd-428d-89eb-634856670ce4
- orphaned file id: c139c5f7-c1e1-400d-9e4c-816defae395a
Do you want to proceed to delete all 2 orphaned file records? [y/N]: y
- Deleting orphaned file records in table upload_files
- Deleting orphaned file records in table tool_files
Removed 2 orphaned file records.     👈👈👈

After: The command keeps images for the app icon, site icon, and avator image.

> docker exec -it docker-api-1 flask clear-orphaned-file-records
...
Starting orphaned file records cleanup.
- Listing message_files records where message_id doesn't exist in messages table
No orphaned message_files records found. There is nothing to delete.
- Listing file records in table upload_files
- Listing file records in table tool_files
Found 3 files in tables.
- Listing file ids in column upload_file_id in table message_files
- Listing file-id-like strings in column data_source_info in table documents
- Listing file-id-like strings in column content in table document_segments
- Listing file-id-like strings in column answer in table messages
- Listing file-id-like strings in column inputs in table workflow_node_executions
- Listing file-id-like strings in column process_data in table workflow_node_executions
- Listing file-id-like strings in column outputs in table workflow_node_executions
- Listing file-id-like strings in column introduction in table conversations
- Listing file-id-like strings in column system_instruction in table conversations
- Listing file-id-like strings in column avatar in table accounts     👈👈👈
- Listing file-id-like strings in column icon in table apps     👈👈👈
- Listing file-id-like strings in column icon in table sites     👈👈👈
- Listing file-id-like JSON string in column inputs in table messages
- Listing file-id-like JSON string in column message in table messages
Found 3 file ids in tables.
No orphaned file records found. There is nothing to delete.     👈👈👈

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20532 **State:** closed **Merged:** Yes --- ## Summary This PR updates the housekeeping commands to prevent them from removing images that are in use as app icons or avatar images, by additionally gathering files on following columns in tables: - `avatar` column in `accounts` table - `icon` column in `apps` and `sites` tables Closes #20531 ## Screenshots **Before**: The command removes app icon and avator images. ```bash > docker exec -it docker-api-1 flask clear-orphaned-file-records ... Starting orphaned file records cleanup. - Listing message_files records where message_id doesn't exist in messages table No orphaned message_files records found. There is nothing to delete. - Listing file records in table upload_files - Listing file records in table tool_files Found 2 files in tables. - Listing file ids in column upload_file_id in table message_files - Listing file-id-like strings in column data_source_info in table documents - Listing file-id-like strings in column content in table document_segments - Listing file-id-like strings in column answer in table messages - Listing file-id-like strings in column inputs in table workflow_node_executions - Listing file-id-like strings in column process_data in table workflow_node_executions - Listing file-id-like strings in column outputs in table workflow_node_executions - Listing file-id-like strings in column introduction in table conversations - Listing file-id-like strings in column system_instruction in table conversations - Listing file-id-like JSON string in column inputs in table messages - Listing file-id-like JSON string in column message in table messages Found 0 file ids in tables. Found 2 orphaned file records. 👈👈👈 - orphaned file id: b28c6aac-cacd-428d-89eb-634856670ce4 - orphaned file id: c139c5f7-c1e1-400d-9e4c-816defae395a Do you want to proceed to delete all 2 orphaned file records? [y/N]: y - Deleting orphaned file records in table upload_files - Deleting orphaned file records in table tool_files Removed 2 orphaned file records. 👈👈👈 ``` **After**: The command keeps images for the app icon, site icon, and avator image. ```bash > docker exec -it docker-api-1 flask clear-orphaned-file-records ... Starting orphaned file records cleanup. - Listing message_files records where message_id doesn't exist in messages table No orphaned message_files records found. There is nothing to delete. - Listing file records in table upload_files - Listing file records in table tool_files Found 3 files in tables. - Listing file ids in column upload_file_id in table message_files - Listing file-id-like strings in column data_source_info in table documents - Listing file-id-like strings in column content in table document_segments - Listing file-id-like strings in column answer in table messages - Listing file-id-like strings in column inputs in table workflow_node_executions - Listing file-id-like strings in column process_data in table workflow_node_executions - Listing file-id-like strings in column outputs in table workflow_node_executions - Listing file-id-like strings in column introduction in table conversations - Listing file-id-like strings in column system_instruction in table conversations - Listing file-id-like strings in column avatar in table accounts 👈👈👈 - Listing file-id-like strings in column icon in table apps 👈👈👈 - Listing file-id-like strings in column icon in table sites 👈👈👈 - Listing file-id-like JSON string in column inputs in table messages - Listing file-id-like JSON string in column message in table messages Found 3 file ids in tables. No orphaned file records found. There is nothing to delete. 👈👈👈 ``` ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [ ] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:31 -05:00
yindo closed this issue 2026-02-21 20:45:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?