langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-25 05:26:11 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20880] fix wrongly remove reset nodes #29512

New Issue
Closed
opened 2026-02-21 20:45:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:42 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20880

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

reproduce:
image
image
expect: the final answer node print streamly
image

truth:

  1. when first chat. first ifelse node execute.
  2. _fetch_node_ids_in_reachable_branch can not fetch all node when the second ifelse's branch_identify is not match.
    for the ifelse2 node' branch_identify is a uuid but the ifelse1 node's branch_identify is true. so the node link break.
    image
  3. then _remove_node_ids_in_unreachable_branch with a 'wrong' reachable_node_ids. this method will remove all nodes
    image
  4. cause the wrong rest_node_ids, then cause the final answer node can not print stream. replaced with blocking answer.
**Original Pull Request:** https://github.com/langgenius/dify/pull/20880 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods reproduce: ![image](https://github.com/user-attachments/assets/819e6ecb-e48e-4c52-a68f-7be9792529b8) ![image](https://github.com/user-attachments/assets/4813ffd3-a342-4339-96b0-e355b5e8c92a) expect: the final answer node print streamly ![image](https://github.com/user-attachments/assets/cd0854e7-2b70-40fc-b8d1-61e4e492ec45) truth: 1. when first chat. first ifelse node execute. 2. ```_fetch_node_ids_in_reachable_branch``` can not fetch all node when the second ifelse's branch_identify is not match. for the ifelse2 node' branch_identify is a uuid but the ifelse1 node's branch_identify is true. so the node link break. ![image](https://github.com/user-attachments/assets/77699ba4-af14-47d1-a3d7-42d5f7330998) 3. then ```_remove_node_ids_in_unreachable_branch``` with a 'wrong' reachable_node_ids. this method will remove all nodes ![image](https://github.com/user-attachments/assets/282a276e-959a-4c4d-845d-356126b498eb) 4. cause the wrong rest_node_ids, then cause the final answer node can not print stream. replaced with blocking answer.
yindo added the pull-request label 2026-02-21 20:45:42 -05:00
yindo closed this issue 2026-02-21 20:45:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29512
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?