langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #20948] fix(auth): Clear login rate limit after password reset #29527

New Issue
Closed
opened 2026-02-21 20:45:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:44 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/20948

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #20925

This Pull Request addresses a bug where a user remains locked out of their account even after a successful password reset. The issue occurs if the user had previously triggered the login rate limit due to multiple failed password attempts.

Problem:
The flask reset-password command did not clear the Redis cache key responsible for tracking login attempt failures. As a result, even with a new, correct password, the system still considered the account locked, preventing successful login and showing a "Too many attempts" error.

Solution:
The fix is to explicitly clear the login rate limit for the user's email immediately after the password has been successfully updated in the database. I've added a call to AccountService.reset_login_error_rate_limit(email) within the reset_password command in api/commands.py.

This ensures that any stale login restriction is removed, allowing the user to log in seamlessly with their new password right after a reset.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/20948 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Fixes #20925 This Pull Request addresses a bug where a user remains locked out of their account even after a successful password reset. The issue occurs if the user had previously triggered the login rate limit due to multiple failed password attempts. **Problem:** The `flask reset-password` command did not clear the Redis cache key responsible for tracking login attempt failures. As a result, even with a new, correct password, the system still considered the account locked, preventing successful login and showing a "Too many attempts" error. **Solution:** The fix is to explicitly clear the login rate limit for the user's email immediately after the password has been successfully updated in the database. I've added a call to `AccountService.reset_login_error_rate_limit(email)` within the `reset_password` command in `api/commands.py`. This ensures that any stale login restriction is removed, allowing the user to log in seamlessly with their new password right after a reset. ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:44 -05:00
yindo closed this issue 2026-02-21 20:45:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29527
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?