langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21023] fix: prevent nodes from being unintentionally deleted by pressing the backspace key. #29546

New Issue
Closed
opened 2026-02-21 20:45:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:46 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21023

State: closed
Merged: Yes

Summary

When editing a workflow or chatflow, pressing the Backspace key to edit text can sometimes delete a node instead if the focus isn’t where we expect.

Also, in the prompt editor of the LLM node, when we type a slash and the picker menu appears, starting from the second time we use it, the picker starts to take focus. As a result, if we keep pressing the Backspace key to delete text, we might accidentally delete a node instead of just deleting text.

This PR fixes these problems with three changes:

  • The Backspace key can no longer be used as a shortcut to delete nodes. Now, only the Delete key can be used to remove nodes. (means partially reverts https://github.com/langgenius/dify/pull/6863)
  • The variable filter input no longer always has autoFocus enabled; it's now optional and enabled by default to avoid unexpected side effects.
  • autoFocus is now disabled for the variable filter picker in the prompt editor.

Thanks to these changes, users can safely press Backspace to delete characters without losing focus or accidentally deleting nodes.

Closes https://github.com/langgenius/dify/issues/20404

Screenshots

Before After
without_pr with_pr

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/21023 **State:** closed **Merged:** Yes --- ## Summary When editing a workflow or chatflow, pressing the Backspace key to edit text can sometimes delete a node instead if the focus isn’t where we expect. Also, in the prompt editor of the LLM node, when we type a slash and the picker menu appears, starting from the second time we use it, the picker starts to take focus. As a result, if we keep pressing the Backspace key to delete text, we might accidentally delete a node instead of just deleting text. This PR fixes these problems with three changes: - The Backspace key can no longer be used as a shortcut to delete nodes. Now, only the Delete key can be used to remove nodes. (means partially reverts https://github.com/langgenius/dify/pull/6863) - The variable filter input no longer always has `autoFocus` enabled; it's now optional and enabled by default to avoid unexpected side effects. - `autoFocus` is now disabled for the variable filter picker in the prompt editor. Thanks to these changes, users can safely press Backspace to delete characters without losing focus or accidentally deleting nodes. Closes https://github.com/langgenius/dify/issues/20404 ## Screenshots | Before | After | |--------|-------| | ![without_pr](https://github.com/user-attachments/assets/9426f3e6-96e7-41fb-9716-0fdbbc5a5afc) | ![with_pr](https://github.com/user-attachments/assets/724b9ad7-4d1e-4b50-8fd2-402b3718b783) | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:46 -05:00
yindo closed this issue 2026-02-21 20:45:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?