langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21044] feat: add redis fallback mechanism #21043 #29547

New Issue
Closed
opened 2026-02-21 20:45:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21044

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #21043.

Summary

This PR introduces a Redis fallback mechanism to improve the resilience of the Dify application when Redis operations fail. The implementation includes:

  • New redis_fallback decorator: A decorator function that gracefully handles Redis operation exceptions and returns configurable default values when Redis is unavailable
  • Enhanced error handling: Applied the fallback mechanism to critical account service methods that depend on Redis for rate limiting functionality
  • Logging integration: Added proper logging to track Redis operation failures for monitoring and debugging purposes

Key Changes:

  • Added redis_fallback decorator in ext_redis.py to handle RedisError exceptions
  • Applied the decorator to rate limiting methods in account_service.py:
    • add_login_error_rate_limit()
    • is_login_error_rate_limit()
    • reset_login_error_rate_limit()
    • add_forgot_password_error_rate_limit()
  • Included comprehensive unit tests to ensure the fallback mechanism works correctly

This enhancement ensures that authentication and rate limiting features continue to function (with degraded capability) even when Redis is temporarily unavailable, preventing complete service disruption.

Fix #21043

Screenshots

Before After
Redis failures would cause unhandled exceptions and potential service disruption Redis failures are gracefully handled with fallback behavior and proper logging

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/21044 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #21043`. ## Summary This PR introduces a Redis fallback mechanism to improve the resilience of the Dify application when Redis operations fail. The implementation includes: - **New `redis_fallback` decorator**: A decorator function that gracefully handles Redis operation exceptions and returns configurable default values when Redis is unavailable - **Enhanced error handling**: Applied the fallback mechanism to critical account service methods that depend on Redis for rate limiting functionality - **Logging integration**: Added proper logging to track Redis operation failures for monitoring and debugging purposes ### Key Changes: - Added `redis_fallback` decorator in `ext_redis.py` to handle `RedisError` exceptions - Applied the decorator to rate limiting methods in `account_service.py`: - `add_login_error_rate_limit()` - `is_login_error_rate_limit()` - `reset_login_error_rate_limit()` - `add_forgot_password_error_rate_limit()` - Included comprehensive unit tests to ensure the fallback mechanism works correctly This enhancement ensures that authentication and rate limiting features continue to function (with degraded capability) even when Redis is temporarily unavailable, preventing complete service disruption. Fix #21043 ## Screenshots | Before | After | |--------|-------| | Redis failures would cause unhandled exceptions and potential service disruption | Redis failures are gracefully handled with fallback behavior and proper logging | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:47 -05:00
yindo closed this issue 2026-02-21 20:45:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?