langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21310] refactor: env check with function #29626

New Issue
Closed
opened 2026-02-21 20:45:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:45:56 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21310

State: closed
Merged: Yes

Summary

This pull request refactors the configuration logic in web/config/index.ts to improve readability and maintainability. The changes replace repetitive code with a reusable helper function for determining boolean configuration values.

Refactoring for improved maintainability:

  • Introduced a helper function getBooleanConfig to centralize the logic for determining boolean configuration values based on environment variables or DOM attributes.
  • Replaced individual configuration logic for ENABLE_WEBSITE_JINAREADER, ENABLE_WEBSITE_FIRECRAWL, and ENABLE_WEBSITE_WATERCRAWL with calls to the new getBooleanConfig function.
  • Simplified default values for enableWebsiteJinaReader, enableWebsiteFireCrawl, and enableWebsiteWaterCrawl by initializing them explicitly before applying configuration logic.

Screenshots

const getBooleanConfig = (envVar: string | undefined, attr: string) => {
  if (envVar !== undefined && envVar !== '')
    return envVar === 'true'
  const attrValue = globalThis.document?.body?.getAttribute(attr)
  if (attrValue !== undefined && attrValue !== '')
    return attrValue === 'true'
  return false
}

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/21310 **State:** closed **Merged:** Yes --- ## Summary This pull request refactors the configuration logic in `web/config/index.ts` to improve readability and maintainability. The changes replace repetitive code with a reusable helper function for determining boolean configuration values. Refactoring for improved maintainability: * Introduced a helper function `getBooleanConfig` to centralize the logic for determining boolean configuration values based on environment variables or DOM attributes. * Replaced individual configuration logic for `ENABLE_WEBSITE_JINAREADER`, `ENABLE_WEBSITE_FIRECRAWL`, and `ENABLE_WEBSITE_WATERCRAWL` with calls to the new `getBooleanConfig` function. * Simplified default values for `enableWebsiteJinaReader`, `enableWebsiteFireCrawl`, and `enableWebsiteWaterCrawl` by initializing them explicitly before applying configuration logic. ## Screenshots ``` const getBooleanConfig = (envVar: string | undefined, attr: string) => { if (envVar !== undefined && envVar !== '') return envVar === 'true' const attrValue = globalThis.document?.body?.getAttribute(attr) if (attrValue !== undefined && attrValue !== '') return attrValue === 'true' return false } ``` ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:45:56 -05:00
yindo closed this issue 2026-02-21 20:45:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?