langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21574] fix: wrong token number when using qa_model and answer is updated. #29705

New Issue
Closed
opened 2026-02-21 20:46:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:05 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21574

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This pull request fixes an issue where the wrong token number was calculated when using the qa_model and the segment answer is updated. Previously, the token count did not include the updated answer in the calculation, which could cause inaccuracies in embedding operations. The fix ensures that the updated segment.answer is included in the token calculation when the document's doc_form is set to "qa_model".

Issue fixed:

Motivation and context:
The fix ensures that token calculations are accurate when the qa_model is used and the answer is updated. This is critical for proper embedding operations in scenarios where the updated answer is necessary for downstream processes.

Dependencies:
No additional dependencies are required for this change.

Screenshots

Before After
The token calculation did not include the updated segment.answer The token calculation now includes the updated segment.answer

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat (backend) and cd web && npx lint-staged (frontend) to appease the lint gods.
**Original Pull Request:** https://github.com/langgenius/dify/pull/21574 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This pull request fixes an issue where the wrong token number was calculated when using the `qa_model` and the segment answer is updated. Previously, the token count did not include the updated answer in the calculation, which could cause inaccuracies in embedding operations. The fix ensures that the updated `segment.answer` is included in the token calculation when the document's `doc_form` is set to `"qa_model"`. **Issue fixed:** - Fix https://github.com/langgenius/dify/issues/21573 **Motivation and context:** The fix ensures that token calculations are accurate when the `qa_model` is used and the answer is updated. This is critical for proper embedding operations in scenarios where the updated answer is necessary for downstream processes. **Dependencies:** No additional dependencies are required for this change. ## Screenshots | Before | After | |--------|-------| | The token calculation did not include the updated `segment.answer` | The token calculation now includes the updated `segment.answer` | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods.
yindo added the pull-request label 2026-02-21 20:46:05 -05:00
yindo closed this issue 2026-02-21 20:46:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29705
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?