langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21796] FIX: dollar-sign escaping in preprocessLaTeX code‐block handling #29753

New Issue
Closed
opened 2026-02-21 20:46:10 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:10 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21796

State: closed
Merged: Yes

Title: Fix dollar-sign escaping in preprocessLaTeX code‐block handling

Summary

close https://github.com/langgenius/dify/issues/20860
When a code block in content contains the dollar sign ($), the current placeholder-based reinsertion uses String.replace() directly, causing the $ to be interpreted as a replacement pattern rather than a literal character. As a result, LaTeX fragments inside code blocks are mangled. This PR:

  • Introduces an escapeReplacement helper to temporarily replace every $ in a code block with a placeholder (_TMP_REPLACE_DOLLAR_).
  • Ensures that when the CODE_BLOCK_PLACEHOLDER is swapped back, the literal dollar signs are restored properly.

test cotent (between start and end)

------ start
若主查询使用 REGEXP_REPLACE(dt.bag_name, ...) 生成字段，ORDER BY 应使用相同表达式：

ORDER BY REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$'), dt.f_ts

✅ 最终修正版 SQL

WITH sampled_bags AS (
    SELECT 
        REGEXP_REPLACE(bag_name, '_reindex_lz4$') AS bag_name,
        bag_md5
    FROM ranked_bags
    WHERE rn <= 4000
)
SELECT 
    REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$', '') AS bag_name,
    dt.timestamp
FROM data_table dt
ORDER BY REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$'), dt.f_ts

------ end

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/21796 **State:** closed **Merged:** Yes --- Title: Fix dollar-sign escaping in preprocessLaTeX code‐block handling ## Summary close https://github.com/langgenius/dify/issues/20860 When a code block in `content` contains the dollar sign (`$`), the current placeholder-based reinsertion uses `String.replace()` directly, causing the `$` to be interpreted as a replacement pattern rather than a literal character. As a result, LaTeX fragments inside code blocks are mangled. This PR: - Introduces an `escapeReplacement` helper to temporarily replace every `$` in a code block with a placeholder (`_TMP_REPLACE_DOLLAR_`). - Ensures that when the `CODE_BLOCK_PLACEHOLDER` is swapped back, the literal dollar signs are restored properly. ## test cotent (between start and end) ------ start 若主查询使用 `REGEXP_REPLACE(dt.bag_name, ...)` 生成字段，`ORDER BY` 应使用相同表达式： ```sql ORDER BY REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$'), dt.f_ts ``` ### ✅ 最终修正版 SQL ```sql WITH sampled_bags AS ( SELECT REGEXP_REPLACE(bag_name, '_reindex_lz4$') AS bag_name, bag_md5 FROM ranked_bags WHERE rn <= 4000 ) SELECT REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$', '') AS bag_name, dt.timestamp FROM data_table dt ORDER BY REGEXP_REPLACE(dt.bag_name, '_reindex_lz4$'), dt.f_ts ``` ------ end ## Screenshots | Before | After | |--------|-------| | ![image](https://github.com/user-attachments/assets/cdb4128c-c228-4508-aa07-d41bda66ea32) | ![image](https://github.com/user-attachments/assets/eb236cb8-f4b3-4854-907b-35969cc7471b) | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:46:10 -05:00
yindo closed this issue 2026-02-21 20:46:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29753
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?