langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-19 16:44:00 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #21867] moving the MessageStatus class from the models.model module to models.enums module #29774

New Issue
Closed
opened 2026-02-21 20:46:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:13 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/21867

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR refactors the codebase by moving the MessageStatus class from the models.model module to models.enums module. This change aims to improve the organization and maintainability of the code by separating enums into their own dedicated module.

Fix #21866

Changes:

  1. Moved MessageStatus Enum:

    • MessageStatus has been relocated to models.enums.
    • Updated all import statements across the codebase to reflect the new location.

  2. Updated References:

    • Replaced hardcoded string comparisons (e.g., "error") with the MessageStatus.ERROR enum value to ensure consistency and reduce potential errors.

  3. Code Cleanup:

    • Removed unused imports and redundant definitions.
    • Ensured all changes adhere to the existing project structure and coding standards.

Motivation:

The refactor ensures better separation of concerns, making the codebase easier to navigate and maintain. It also reduces the potential for errors caused by duplicate or inconsistent definitions of enums.

Dependencies:

No new dependencies were introduced as part of this change.

Screenshots

Before After
Hardcoded "error" values and scattered enum definitions Centralized MessageStatus in models.enums

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods.
**Original Pull Request:** https://github.com/langgenius/dify/pull/21867 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR refactors the codebase by moving the `MessageStatus` class from the `models.model` module to `models.enums` module. This change aims to improve the organization and maintainability of the code by separating enums into their own dedicated module. Fix #21866 ### Changes: 1. **Moved `MessageStatus` Enum**: - `MessageStatus` has been relocated to `models.enums`. - Updated all import statements across the codebase to reflect the new location. 2. **Updated References**: - Replaced hardcoded string comparisons (e.g., `"error"`) with the `MessageStatus.ERROR` enum value to ensure consistency and reduce potential errors. 3. **Code Cleanup**: - Removed unused imports and redundant definitions. - Ensured all changes adhere to the existing project structure and coding standards. ### Motivation: The refactor ensures better separation of concerns, making the codebase easier to navigate and maintain. It also reduces the potential for errors caused by duplicate or inconsistent definitions of enums. ### Dependencies: No new dependencies were introduced as part of this change. ## Screenshots | Before | After | |--------|-------| | Hardcoded `"error"` values and scattered enum definitions | Centralized `MessageStatus` in `models.enums` | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods.
yindo added the pull-request label 2026-02-21 20:46:13 -05:00
yindo closed this issue 2026-02-21 20:46:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?