langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22242] minor fix: wrong and #29876

New Issue
Closed
opened 2026-02-21 20:46:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22242

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR fixes an incorrect logical operator in the database query filter for the AppMCPServer controller. The issue was in the get method where the filter condition was using the and operator incorrectly within a single filter statement, which would cause a logical error in the SQL query generation.

Changes made:

  • Split the combined filter condition AppMCPServer.id == server_id and AppMCPServer.tenant_id == current_user.current_tenant_id into two separate .filter() calls
  • This ensures proper SQLAlchemy query construction and prevents potential runtime errors

Technical details:

  • File: api/controllers/console/app
  • Method: get(self, server_id)
  • Lines changed: 95-96
  • Type: Bug fix

The change improves code reliability by following SQLAlchemy best practices for chaining multiple filter conditions.

Screenshots

Before After
N/A - Backend logic fix N/A - Backend logic fix

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/22242 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR fixes an incorrect logical operator in the database query filter for the AppMCPServer controller. The issue was in the `get` method where the filter condition was using the `and` operator incorrectly within a single filter statement, which would cause a logical error in the SQL query generation. **Changes made:** - Split the combined filter condition `AppMCPServer.id == server_id and AppMCPServer.tenant_id == current_user.current_tenant_id` into two separate `.filter()` calls - This ensures proper SQLAlchemy query construction and prevents potential runtime errors **Technical details:** - **File:** `api/controllers/console/app` - **Method:** `get(self, server_id)` - **Lines changed:** 95-96 - **Type:** Bug fix The change improves code reliability by following SQLAlchemy best practices for chaining multiple filter conditions. ## Screenshots | Before | After | |--------|-------| | N/A - Backend logic fix | N/A - Backend logic fix | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:46:25 -05:00
yindo closed this issue 2026-02-21 20:46:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?