langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22276] The s3 signature_version supports transparent passing of environment … #29885

New Issue
Closed
opened 2026-02-21 20:46:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:26 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22276

State: closed
Merged: No

The s3 signature_version supports transparent passing of environment variables

This update modifies the api/extensions/storage/aws_s3_storage.py file to handle the signature_version parameter dynamically. The changes include adding support for the S3_SIGNATURE_VERSION environment variable, which can be set to 'unsigned', 's3', 's3v4', or any custom input. The code now checks the environment variable dif_config.S3_SIGNATURE_VERSION and defaults to 's3' if not specified. While 'unsigned' is handled as a special case, other values are transparently passed to the boto3 client configuration without additional processing, offering flexibility for advanced setups. This enhancement provides greater control and adaptability for S3 storage operations.

**Original Pull Request:** https://github.com/langgenius/dify/pull/22276 **State:** closed **Merged:** No --- # The s3 signature_version supports transparent passing of environment variables This update modifies the `api/extensions/storage/aws_s3_storage.py` file to handle the `signature_version` parameter dynamically. The changes include adding support for the `S3_SIGNATURE_VERSION` environment variable, which can be set to `'unsigned'`, `'s3'`, `'s3v4'`, or any custom input. The code now checks the environment variable `dif_config.S3_SIGNATURE_VERSION` and defaults to `'s3'` if not specified. While `'unsigned'` is handled as a special case, other values are transparently passed to the boto3 client configuration without additional processing, offering flexibility for advanced setups. This enhancement provides greater control and adaptability for S3 storage operations.
yindo added the pull-request label 2026-02-21 20:46:26 -05:00
yindo closed this issue 2026-02-21 20:46:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?