langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22359] chore: Add fonts-noto-cjk dependency for pypdfium2 #29909

New Issue
Closed
opened 2026-02-21 20:46:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22359

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes: #22358
This PR installs the fonts-noto-cjk package in the api/Dockerfile to fix a regression where text extraction from certain CJK (Chinese, Japanese, Korean) PDFs results in empty content.
Problem:
The PDF processing library, pypdfium2, requires system fonts to correctly render and extract text from PDFs that do not have their fonts embedded. Without these fonts, the text extraction process fails silently, marking the document as "completed" but with empty or incomplete
content.

Cause of Regression:
This issue is a regression introduced in PR #15837, which removed the fonts-noto-cjk package. The removal was intended to clean up dependencies for the matplotlib tool after it was migrated to a plugin. However, this overlooked the implicit dependency that pypdfium2 has on these
system fonts for its core functionality.

Solution:
By re-adding the fonts-noto-cjk package, this change ensures reliable text extraction for a wider range of PDF documents, restoring the previous functionality and resolving the regression. A comment has been added to the Dockerfile to clarify why this package is necessary, preventing
future accidental removal.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/22359 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Fixes: #22358 This PR installs the fonts-noto-cjk package in the api/Dockerfile to fix a regression where text extraction from certain CJK (Chinese, Japanese, Korean) PDFs results in empty content. Problem: The PDF processing library, pypdfium2, requires system fonts to correctly render and extract text from PDFs that do not have their fonts embedded. Without these fonts, the text extraction process fails silently, marking the document as "completed" but with empty or incomplete content. Cause of Regression: This issue is a regression introduced in PR #15837, which removed the fonts-noto-cjk package. The removal was intended to clean up dependencies for the matplotlib tool after it was migrated to a plugin. However, this overlooked the implicit dependency that pypdfium2 has on these system fonts for its core functionality. Solution: By re-adding the fonts-noto-cjk package, this change ensures reliable text extraction for a wider range of PDF documents, restoring the previous functionality and resolving the regression. A comment has been added to the Dockerfile to clarify why this package is necessary, preventing future accidental removal. <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:46:29 -05:00
yindo closed this issue 2026-02-21 20:46:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?