langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22590] Fix #22508 #29981

New Issue
Closed
opened 2026-02-21 20:46:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22590

State: closed
Merged: Yes

Fix: Enable editing of iteration output values

Fixes #22508

Summary

This PR fixes the issue where users cannot edit iteration output values in the variable inspect view. The problem was caused by the iteration node returning VarType.any which causes the JSON editor to be disabled for data validation reasons.

Root Cause: The JSON editor in the variable inspect view is intentionally disabled for array[any] types to avoid data validation issues, as array[any] cannot be strongly typed or validated.

Solution: Changed the return type from VarType.any to VarType.arrayObject to provide more specific typing, which allows the JSON editor to function properly while maintaining type safety.

Changes Made

  • Updated iteration node to return VarType.arrayObject instead of VarType.any
  • This enables the JSON editor for iteration outputs while maintaining proper type validation

Testing

  • Verified that iteration outputs can now be edited in the variable inspect view
  • Confirmed that the JSON editor works correctly with the new type
  • Tested that existing functionality remains unaffected

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/22590 **State:** closed **Merged:** Yes --- # Fix: Enable editing of iteration output values Fixes #22508 ## Summary This PR fixes the issue where users cannot edit iteration output values in the variable inspect view. The problem was caused by the iteration node returning `VarType.any` which causes the JSON editor to be disabled for data validation reasons. **Root Cause:** The JSON editor in the variable inspect view is intentionally disabled for `array[any]` types to avoid data validation issues, as `array[any]` cannot be strongly typed or validated. **Solution:** Changed the return type from `VarType.any` to `VarType.arrayObject` to provide more specific typing, which allows the JSON editor to function properly while maintaining type safety. ## Changes Made - Updated iteration node to return `VarType.arrayObject` instead of `VarType.any` - This enables the JSON editor for iteration outputs while maintaining proper type validation ## Testing - [x] Verified that iteration outputs can now be edited in the variable inspect view - [x] Confirmed that the JSON editor works correctly with the new type - [x] Tested that existing functionality remains unaffected ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:46:37 -05:00
yindo closed this issue 2026-02-21 20:46:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#29981
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?