langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 13:05:55 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22705] test: add comprehensive unit tests for Firecrawl and Watercrawl auth providers #30023

New Issue
Closed
opened 2026-02-21 20:46:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:42 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22705

State: closed
Merged: Yes

Description

Add comprehensive unit tests for Firecrawl and Watercrawl auth service modules.

Core Functionality Tests

  • Bearer authentication initialization and validation for Firecrawl
  • X-API-KEY authentication initialization and validation for Watercrawl
  • Custom base URL configuration support
  • Credential validation via respective API endpoints
  • Proper HTTP header construction for both authentication types

Security-Focused Tests

  • Authentication type validation: Ensures only correct auth types are accepted (Bearer for Firecrawl, x-api-key for Watercrawl)
  • API key presence validation: Rejects empty, null, or missing API keys with appropriate errors
  • API key confidentiality: Verifies that sensitive API keys are never exposed in error messages or logs
  • Secure error handling: Tests that error responses don't leak implementation details or sensitive information

Edge Cases

  • Invalid authentication types (basic, wrong type, empty strings)
  • Missing or malformed API key configurations
  • HTTP error responses (402 Payment Required, 403 Forbidden, 404 Not Found, 409 Conflict, 500 Internal Server Error)
  • Malformed JSON responses and parsing errors
  • Network failures (ConnectionError, Timeout, ReadTimeout, ConnectTimeout)
  • URL construction edge cases (trailing slashes, double slashes handling)
  • Custom base URL validation during API calls

The extensive test coverage is intentional given the critical nature of authentication functionality in the system.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/22705 **State:** closed **Merged:** Yes --- ## Description ### Add comprehensive unit tests for Firecrawl and Watercrawl auth service modules. ### Core Functionality Tests - Bearer authentication initialization and validation for Firecrawl - X-API-KEY authentication initialization and validation for Watercrawl - Custom base URL configuration support - Credential validation via respective API endpoints - Proper HTTP header construction for both authentication types ### Security-Focused Tests - **Authentication type validation**: Ensures only correct auth types are accepted (Bearer for Firecrawl, x-api-key for Watercrawl) - **API key presence validation**: Rejects empty, null, or missing API keys with appropriate errors - **API key confidentiality**: Verifies that sensitive API keys are never exposed in error messages or logs - **Secure error handling**: Tests that error responses don't leak implementation details or sensitive information ### Edge Cases - Invalid authentication types (basic, wrong type, empty strings) - Missing or malformed API key configurations - HTTP error responses (402 Payment Required, 403 Forbidden, 404 Not Found, 409 Conflict, 500 Internal Server Error) - Malformed JSON responses and parsing errors - Network failures (ConnectionError, Timeout, ReadTimeout, ConnectTimeout) - URL construction edge cases (trailing slashes, double slashes handling) - Custom base URL validation during API calls The extensive test coverage is intentional given the critical nature of authentication functionality in the system. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:46:42 -05:00
yindo closed this issue 2026-02-21 20:46:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?