langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #22814] fix: private.pem keyPath error in windows #30067

New Issue
Closed
opened 2026-02-21 20:46:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/22814

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Fixes #22813

Summary

This PR resolves Windows path compatibility issues for private key storage by replacing hardcoded path concatenation with os.path.join().

Key changes:

  • Replaced "privkeys/{tenant_id}/private.pem" with os.path.join("privkeys", tenant_id, "private.pem")
  • Ensured cross-platform compatibility for file operations
  • Maintained backward compatibility with existing key storage

Impact:

  • Fixes FileNotFoundError on Windows systems
  • No behavior change on Unix-like systems
  • No database or API changes required

Screenshots

Before (Error on Windows) After (Working on Windows)

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Test Coverage:

  • Added test cases for:
    • Windows-style path resolution
    • Linux-style path resolution
    • Tenant isolation verification
**Original Pull Request:** https://github.com/langgenius/dify/pull/22814 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. Fixes #22813 ## Summary This PR resolves Windows path compatibility issues for private key storage by replacing hardcoded path concatenation with `os.path.join()`. **Key changes:** - Replaced `"privkeys/{tenant_id}/private.pem"` with `os.path.join("privkeys", tenant_id, "private.pem")` - Ensured cross-platform compatibility for file operations - Maintained backward compatibility with existing key storage **Impact:** - Fixes `FileNotFoundError` on Windows systems - No behavior change on Unix-like systems - No database or API changes required ## Screenshots | Before (Error on Windows) | After (Working on Windows) | |---------------------------|---------------------------| ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods **Test Coverage:** - Added test cases for: - Windows-style path resolution - Linux-style path resolution - Tenant isolation verification
yindo added the pull-request label 2026-02-21 20:46:47 -05:00
yindo closed this issue 2026-02-21 20:46:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?