langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23065] fix(i18n): Complete missing translations and clean up legacy keys in app-debug across all locales (#23062) #30143

New Issue
Closed
opened 2026-02-21 20:46:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:46:56 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23065

State: closed
Merged: Yes

Summary

Fixes #23062

This PR completely resolves the missing upload feature translations across all supported locales in Dify. The issue was that many languages were missing critical translation keys for audioUpload, fileUpload, imageUpload, and documentUpload features, causing English fallback text to appear in non-English UI.

Problem

  • Multiple locales were missing upload feature translations, particularly audioUpload
  • Users experienced English fallback text when using multimodal features in non-English languages
  • Inconsistent translation coverage across the 20 supported locales
  • Poor user experience for non-English speakers using audio upload functionality

Solution

  • Complete coverage: Added missing upload feature translations to ALL 20 supported locales
  • Comprehensive structure: Ensured all locales have consistent fileUpload, imageUpload, documentUpload, and audioUpload translations
  • Quality assurance: Added robust Jest test suite to prevent future regressions
  • Code cleanup: Removed legacy keys (varNameRequired) and added missing warning message translations

Impact

  • ✅ 100% translation coverage for upload features across all 20 locales
  • ✅ Zero English fallbacks for upload functionality in any supported language
  • ✅ Improved UX for all non-English users using multimodal features
  • ✅ Future-proofed with comprehensive test coverage

Screenshots

Before After
English fallback text appearing in non-English UI for upload features Properly localized upload feature text in all supported languages

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Additional Details

Files Modified:

  • 20 app-debug.ts files across all supported locales
  • Added comprehensive Jest test suite (web/__tests__/i18n-upload-features.test.ts)

Translation Coverage:

  • fileUpload: 20/20 languages ✅
  • imageUpload: 20/20 languages ✅
  • documentUpload: 20/20 languages ✅
  • audioUpload: 20/20 languages ✅

Test Coverage:

  • 4 comprehensive test cases validating upload feature presence
  • Specific validation for previously missing locales
  • All tests pass successfully

This resolves the core internationalization issue and ensures a consistent, localized experience for all Dify users regardless of their language preference.

**Original Pull Request:** https://github.com/langgenius/dify/pull/23065 **State:** closed **Merged:** Yes --- ## Summary Fixes #23062 This PR completely resolves the missing upload feature translations across all supported locales in Dify. The issue was that many languages were missing critical translation keys for `audioUpload`, `fileUpload`, `imageUpload`, and `documentUpload` features, causing English fallback text to appear in non-English UI. ### Problem - Multiple locales were missing upload feature translations, particularly `audioUpload` - Users experienced English fallback text when using multimodal features in non-English languages - Inconsistent translation coverage across the 20 supported locales - Poor user experience for non-English speakers using audio upload functionality ### Solution - **Complete coverage**: Added missing upload feature translations to ALL 20 supported locales - **Comprehensive structure**: Ensured all locales have consistent `fileUpload`, `imageUpload`, `documentUpload`, and `audioUpload` translations - **Quality assurance**: Added robust Jest test suite to prevent future regressions - **Code cleanup**: Removed legacy keys (`varNameRequired`) and added missing warning message translations ### Impact - ✅ **100% translation coverage** for upload features across all 20 locales - ✅ **Zero English fallbacks** for upload functionality in any supported language - ✅ **Improved UX** for all non-English users using multimodal features - ✅ **Future-proofed** with comprehensive test coverage ## Screenshots | Before | After | |--------|-------| | English fallback text appearing in non-English UI for upload features | Properly localized upload feature text in all supported languages | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods ### Additional Details **Files Modified:** - 20 `app-debug.ts` files across all supported locales - Added comprehensive Jest test suite (`web/__tests__/i18n-upload-features.test.ts`) **Translation Coverage:** - `fileUpload`: 20/20 languages ✅ - `imageUpload`: 20/20 languages ✅ - `documentUpload`: 20/20 languages ✅ - `audioUpload`: 20/20 languages ✅ **Test Coverage:** - 4 comprehensive test cases validating upload feature presence - Specific validation for previously missing locales - All tests pass successfully This resolves the core internationalization issue and ensures a consistent, localized experience for all Dify users regardless of their language preference.
yindo added the pull-request label 2026-02-21 20:46:56 -05:00
yindo closed this issue 2026-02-21 20:46:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30143
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?