langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23160] fix: improve boolean field handling in plugin configuration forms #30183

New Issue
Closed
opened 2026-02-21 20:47:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:00 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23160

State: closed
Merged: Yes

Summary

This PR fixes an Internal Server Error that occurs when configuring endpoints in the Slack bot extension. The error was caused by improper handling of boolean fields in plugin configuration forms, where boolean values were being sent to the backend as strings or numbers instead of proper boolean types.

Problem

When users try to configure the Slack bot endpoint, they encounter an "Internal Server Error" message because:

Form fields with boolean type are being submitted as strings ("true", "false") or numbers (1, 0) instead of actual boolean values
The backend validation rejects these malformed boolean data types, causing the server to return a 500 error
This prevents users from successfully configuring Slack bot endpoints

Solution

The fix implements proper boolean field handling in two key areas:

Form Schema Processing (web/app/components/tools/utils/to-form-schema.ts):

Added boolean field conversion logic in addDefaultValue function
Converts string values ('true', '1', 'True') to proper boolean true
Converts number values (1) to boolean true, others to false

Preserves existing boolean values

Endpoint Configuration (web/app/components/plugins/plugin-detail-panel/endpoint-modal.tsx):
Added boolean field processing in handleSave function before calling onSaved
Creates a processed copy of form data with correct boolean types
Ensures all boolean fields are properly typed before sending to backend

Impact

✅ Fixes: Internal Server Error when configuring Slack bot endpoints
✅ Improves: Plugin configuration form reliability and user experience
✅ Maintains: Backward compatibility with existing functionality
✅ Enables: Users to successfully configure Slack bot endpoints without errors

Testing

Tested with Slack bot endpoint configuration forms
Verified boolean fields are properly converted from string/number to boolean
Confirmed no more Internal Server Error when saving endpoint configuration
Validated that existing functionality remains intact

**Original Pull Request:** https://github.com/langgenius/dify/pull/23160 **State:** closed **Merged:** Yes --- Summary This PR fixes an Internal Server Error that occurs when configuring endpoints in the Slack bot extension. The error was caused by improper handling of boolean fields in plugin configuration forms, where boolean values were being sent to the backend as strings or numbers instead of proper boolean types. Problem When users try to configure the Slack bot endpoint, they encounter an "Internal Server Error" message because: Form fields with boolean type are being submitted as strings ("true", "false") or numbers (1, 0) instead of actual boolean values The backend validation rejects these malformed boolean data types, causing the server to return a 500 error This prevents users from successfully configuring Slack bot endpoints Solution The fix implements proper boolean field handling in two key areas: Form Schema Processing (web/app/components/tools/utils/to-form-schema.ts): Added boolean field conversion logic in addDefaultValue function Converts string values ('true', '1', 'True') to proper boolean true Converts number values (1) to boolean true, others to false Preserves existing boolean values Endpoint Configuration (web/app/components/plugins/plugin-detail-panel/endpoint-modal.tsx): Added boolean field processing in handleSave function before calling onSaved Creates a processed copy of form data with correct boolean types Ensures all boolean fields are properly typed before sending to backend Impact ✅ Fixes: Internal Server Error when configuring Slack bot endpoints ✅ Improves: Plugin configuration form reliability and user experience ✅ Maintains: Backward compatibility with existing functionality ✅ Enables: Users to successfully configure Slack bot endpoints without errors Testing Tested with Slack bot endpoint configuration forms Verified boolean fields are properly converted from string/number to boolean Confirmed no more Internal Server Error when saving endpoint configuration Validated that existing functionality remains intact
yindo added the pull-request label 2026-02-21 20:47:00 -05:00
yindo closed this issue 2026-02-21 20:47:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30183
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?