langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23232] fix(api): "Message not exists" error while creating feedback by admin #30208

New Issue
Closed
opened 2026-02-21 20:47:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23232

State: closed
Merged: Yes

PR #22580 introduced a regression in the admin feedback functionality. The original code correctly
allowed dashboard users to create/update feedback on any message within an app they have access to,
filtering only by app_id and message_id.

The refactored code, while appearing consistent with the existing codebase, inadvertently added user-specific
filtering through MessageService.get_message(). This method filters messages by the current dashboard
user's ID (from_account_id), breaking the intended behavior.

Reproduction scenario:

  1. EndUser with ID end_user_123 creates a message
  2. Dashboard user with ID dashboard_user_456 attempts to create feedback via the admin API

Result:

  • Original code: Successfully finds the message and creates feedback
  • Refactored code: Fails with "Message not exists" error due to user ID mismatch

The refactored implementation incorrectly filters messages when admin is creating feedbacks,
which contradicts the intended admin workflow where any authorized dashboard user should be able
to moderate any message within their accessible apps.

**Original Pull Request:** https://github.com/langgenius/dify/pull/23232 **State:** closed **Merged:** Yes --- PR #22580 introduced a regression in the admin feedback functionality. The original code correctly allowed dashboard users to create/update feedback on any message within an app they have access to, filtering only by `app_id` and `message_id`. The refactored code, while appearing consistent with the existing codebase, inadvertently added user-specific filtering through `MessageService.get_message()`. This method filters messages by the current dashboard user's ID (`from_account_id`), breaking the intended behavior. Reproduction scenario: 1. EndUser with ID `end_user_123` creates a message 2. Dashboard user with ID `dashboard_user_456` attempts to create feedback via the admin API Result: - Original code: Successfully finds the message and creates feedback - Refactored code: Fails with "Message not exists" error due to user ID mismatch The refactored implementation incorrectly filters messages when admin is creating feedbacks, which contradicts the intended admin workflow where any authorized dashboard user should be able to moderate any message within their accessible apps.
yindo added the pull-request label 2026-02-21 20:47:03 -05:00
yindo closed this issue 2026-02-21 20:47:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?