langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23406] fix: remove redundant useEffect from TagSelector component #30264

New Issue
Closed
opened 2026-02-21 20:47:09 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:09 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23406

State: closed
Merged: Yes

Summary

This PR removes the redundant useEffect from the TagSelector component that was causing duplicate API requests for tags.

Context:

  • Related to PR #23329 which removed TagSelector from app sidebar
  • All pages using TagSelector already have TagFilter component that handles tag fetching
  • This creates unnecessary duplicate tags?type=app API calls on page load

Changes:

  • Removed useEffect that automatically fetches tags in TagSelector component
  • Preserved getTagList function for Panel's onCreate callback (used when creating new tags)
  • Establishes clear architectural separation:
    • TagFilter: Data fetching layer
    • TagSelector: Display and interaction layer

Benefits:

  • Eliminates duplicate API requests on page load
  • Improves performance by reducing unnecessary network calls
  • Simplifies component architecture with clear responsibility separation
  • Maintains functionality for tag creation workflows

Screenshots

Before After
Multiple tags?type=app requests on apps page load Single request from TagFilter only

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23406 **State:** closed **Merged:** Yes --- ## Summary This PR removes the redundant `useEffect` from the TagSelector component that was causing duplicate API requests for tags. **Context:** - Related to PR #23329 which removed TagSelector from app sidebar - All pages using TagSelector already have TagFilter component that handles tag fetching - This creates unnecessary duplicate `tags?type=app` API calls on page load **Changes:** - Removed `useEffect` that automatically fetches tags in TagSelector component - Preserved `getTagList` function for Panel's `onCreate` callback (used when creating new tags) - Establishes clear architectural separation: - **TagFilter**: Data fetching layer - **TagSelector**: Display and interaction layer **Benefits:** - Eliminates duplicate API requests on page load - Improves performance by reducing unnecessary network calls - Simplifies component architecture with clear responsibility separation - Maintains functionality for tag creation workflows ## Screenshots | Before | After | |--------|-------| | Multiple `tags?type=app` requests on apps page load | Single request from TagFilter only | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:09 -05:00
yindo closed this issue 2026-02-21 20:47:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30264
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?