langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-27 11:11:21 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23466] Feat add testcontainers test for workflow draft variable service #30280

New Issue
Closed
opened 2026-02-21 20:47:11 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:11 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23466

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR introduces comprehensive integration tests for the Workflow Draft Variable Service in the Dify API. The test suite covers all major functionalities of the service including variable retrieval, creation, updating, deletion, and conversation variable management.

Fix #23465

Key Changes:

  • Added TestWorkflowDraftVariableService class with comprehensive test coverage
  • Implemented tests for variable CRUD operations (Create, Read, Update, Delete)
  • Added tests for conversation variable management and prefilling default values
  • Included tests for node variable operations and system variable listing
  • Added proper mocking for external service dependencies
  • Ensured error handling tests for edge cases (not found, not editable scenarios)

Test Coverage Includes:

  • Variable retrieval by ID and name
  • Draft variable selection by selectors
  • Variable listing with and without values
  • Node and conversation variable operations
  • Variable update and deletion workflows
  • System variable management
  • Error scenarios and edge cases

This enhancement improves the reliability and maintainability of the workflow draft variable functionality by providing thorough test coverage.

Screenshots

Before After
No integration tests for workflow draft variable service Comprehensive test suite with 18+ test methods covering all service operations

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23466 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR introduces comprehensive integration tests for the Workflow Draft Variable Service in the Dify API. The test suite covers all major functionalities of the service including variable retrieval, creation, updating, deletion, and conversation variable management. Fix #23465 **Key Changes:** - Added `TestWorkflowDraftVariableService` class with comprehensive test coverage - Implemented tests for variable CRUD operations (Create, Read, Update, Delete) - Added tests for conversation variable management and prefilling default values - Included tests for node variable operations and system variable listing - Added proper mocking for external service dependencies - Ensured error handling tests for edge cases (not found, not editable scenarios) **Test Coverage Includes:** - Variable retrieval by ID and name - Draft variable selection by selectors - Variable listing with and without values - Node and conversation variable operations - Variable update and deletion workflows - System variable management - Error scenarios and edge cases This enhancement improves the reliability and maintainability of the workflow draft variable functionality by providing thorough test coverage. ## Screenshots | Before | After | |--------|-------| | No integration tests for workflow draft variable service | Comprehensive test suite with 18+ test methods covering all service operations | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:11 -05:00
yindo closed this issue 2026-02-21 20:47:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30280
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?