langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23542] Fixes #23536 #30297

New Issue
Closed
opened 2026-02-21 20:47:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:13 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23542

State: closed
Merged: Yes

Describe

Fix https://github.com/langgenius/dify/issues/23536

Summary

This PR removes redundant @use imports from markdown.scss that were reintroducing theme variables (light, dark, markdown-light, markdown-dark) and unintentionally overriding variables defined in manual-light.css and manual-dark.css.

Changes

  • Removed @use statements from markdown.scss that imported global theme modules
  • Ensured that manual theme variables defined in global.css take precedence

Reason

Due to the load order, markdown.scss was emitting :root variable definitions after manual-*.css, causing manual overrides to be ignored. Removing the imports resolves this issue.

Impact

  • Manual theme variable overrides (e.g. colors, spacing) now work as expected
  • No functional loss, assuming variables are already defined globally via globals.css

Notes

If further theming is needed in markdown.scss, consider importing only mixins or variables locally, not emitting :root rules again.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23542 **State:** closed **Merged:** Yes --- ## Describe Fix https://github.com/langgenius/dify/issues/23536 ### Summary This PR removes redundant `@use` imports from `markdown.scss` that were reintroducing theme variables (`light`, `dark`, `markdown-light`, `markdown-dark`) and unintentionally overriding variables defined in `manual-light.css` and `manual-dark.css`. ### Changes - Removed `@use` statements from `markdown.scss` that imported global theme modules - Ensured that manual theme variables defined in `global.css` take precedence ### Reason Due to the load order, `markdown.scss` was emitting `:root` variable definitions after `manual-*.css`, causing manual overrides to be ignored. Removing the imports resolves this issue. ### Impact - Manual theme variable overrides (e.g. colors, spacing) now work as expected - No functional loss, assuming variables are already defined globally via `globals.css` ### Notes If further theming is needed in `markdown.scss`, consider importing only mixins or variables locally, not emitting `:root` rules again. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:13 -05:00
yindo closed this issue 2026-02-21 20:47:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30297
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?