langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-28 05:20:07 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23662] fix: change i18n workflow trigger mechanism to run in main repository #30343

New Issue
Closed
opened 2026-02-21 20:47:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23662

State: closed
Merged: Yes

Summary

This PR fixes the i18n translation workflow that was consistently failing due to permission issues. The workflow was triggering in fork repositories without proper permissions to create pull requests back to the main repository.

Key changes:

  • Changed trigger from pull_request: types: [closed] to push events on main branch
  • Added path filtering to only trigger when web/i18n/en-US/*.ts files are modified
  • Added repository check to ensure execution only in langgenius/dify main repository
  • Removed unnecessary comments from the workflow file

This ensures the i18n translation automation runs with proper permissions in the main repository and creates translation update PRs successfully.

Fixes #23661

Screenshots

Before After
Workflow fails in fork repos with "Permission denied" errors Workflow runs in main repo with proper permissions

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23662 **State:** closed **Merged:** Yes --- ## Summary This PR fixes the i18n translation workflow that was consistently failing due to permission issues. The workflow was triggering in fork repositories without proper permissions to create pull requests back to the main repository. **Key changes:** - Changed trigger from `pull_request: types: [closed]` to `push` events on main branch - Added path filtering to only trigger when `web/i18n/en-US/*.ts` files are modified - Added repository check to ensure execution only in `langgenius/dify` main repository - Removed unnecessary comments from the workflow file This ensures the i18n translation automation runs with proper permissions in the main repository and creates translation update PRs successfully. Fixes #23661 ## Screenshots | Before | After | |--------|-------| | Workflow fails in fork repos with "Permission denied" errors | Workflow runs in main repo with proper permissions | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:19 -05:00
yindo closed this issue 2026-02-21 20:47:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30343
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?