langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23667] fix: resolve datasets container rounded corners disappearing during scroll #30345

New Issue
Closed
opened 2026-02-21 20:47:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23667

State: closed
Merged: Yes

[!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #23664.

Summary

This PR fixes the rounded corners disappearing issue when scrolling on the Knowledge Base API page. The main problem was that during scrolling, the article content would move behind a sticky header, causing the rounded corners to be visually clipped or masked, creating an appearance of straight corners instead of the intended rounded corners.

Additionally, this PR addresses an existing blue outline focus issue that wasn't mentioned in the original issue but was introduced during the fix process. When the container gained focus (e.g., when clicking on API Access tab), a blue browser default outline would appear around the rounded container.

Key Changes:

  • Fixed rounded corners visual clipping during scroll by optimizing container and header styling
  • Implemented conditional background colors for different tab contexts
  • Removed unwanted blue focus outline from scroll container
  • Improved tab button hover styling for better visual feedback
  • Optimized header spacing and border consistency

Root Cause: The original issue occurred because rounded containers would have their corners visually masked by sticky headers during scroll, and the container focus behavior caused additional blue outline issues.

Fixes #23664

Screenshots

Before After
Rounded corners disappear during scroll, blue outline appears on focus Consistent rounded corners maintained during scroll, clean focus behavior

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23667 **State:** closed **Merged:** Yes --- > [\!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #23664`. ## Summary This PR fixes the rounded corners disappearing issue when scrolling on the Knowledge Base API page. The main problem was that during scrolling, the article content would move behind a sticky header, causing the rounded corners to be visually clipped or masked, creating an appearance of straight corners instead of the intended rounded corners. Additionally, this PR addresses an existing blue outline focus issue that wasn't mentioned in the original issue but was introduced during the fix process. When the container gained focus (e.g., when clicking on API Access tab), a blue browser default outline would appear around the rounded container. **Key Changes:** - Fixed rounded corners visual clipping during scroll by optimizing container and header styling - Implemented conditional background colors for different tab contexts - Removed unwanted blue focus outline from scroll container - Improved tab button hover styling for better visual feedback - Optimized header spacing and border consistency **Root Cause:** The original issue occurred because rounded containers would have their corners visually masked by sticky headers during scroll, and the container focus behavior caused additional blue outline issues. Fixes #23664 ## Screenshots | Before | After | |--------|-------| | Rounded corners disappear during scroll, blue outline appears on focus | Consistent rounded corners maintained during scroll, clean focus behavior | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:19 -05:00
yindo closed this issue 2026-02-21 20:47:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30345
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?