langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23715] fix: unified error handling for GotoAnything search actions #30370

New Issue
Closed
opened 2026-02-21 20:47:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23715

State: closed
Merged: Yes

Fixes #23714

Summary

This PR addresses two consistency issues in the GotoAnything search functionality:

  1. Unified error handling: Ensures all search actions (@plugin, @app, @knowledge) handle API failures gracefully by returning empty arrays instead of throwing errors to the UI layer.

  2. Consistent @node behavior: Aligns @node search behavior with other search types by showing all available workflow nodes when typing just "@node", instead of showing help text.

Changes

  • Added comprehensive error handling with try-catch blocks in all search actions
  • Implemented dual-layer error protection (action level + unified entry point)
  • Modified @node search to display all nodes when no search term provided
  • Added 12 test cases covering error scenarios and edge cases

Screenshots

Before After
@plugin search fails → "search failed" error @plugin search fails → "no results" message
@node → help text @node → list of all workflow nodes

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23715 **State:** closed **Merged:** Yes --- Fixes #23714 ## Summary This PR addresses two consistency issues in the GotoAnything search functionality: 1. **Unified error handling**: Ensures all search actions (@plugin, @app, @knowledge) handle API failures gracefully by returning empty arrays instead of throwing errors to the UI layer. 2. **Consistent @node behavior**: Aligns @node search behavior with other search types by showing all available workflow nodes when typing just "@node", instead of showing help text. ## Changes - Added comprehensive error handling with try-catch blocks in all search actions - Implemented dual-layer error protection (action level + unified entry point) - Modified @node search to display all nodes when no search term provided - Added 12 test cases covering error scenarios and edge cases ## Screenshots | Before | After | |--------|-------| | @plugin search fails → "search failed" error | @plugin search fails → "no results" message | | @node → help text | @node → list of all workflow nodes | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:22 -05:00
yindo closed this issue 2026-02-21 20:47:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?