langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23791] fix: remove misleading clear buttons and improve SimpleSelect UX #30399

New Issue
Closed
opened 2026-02-21 20:47:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23791

State: closed
Merged: Yes

[!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #23790.

Fixes #23790

Summary

This PR fixes misleading clear buttons in language/timezone settings and improves SimpleSelect component UX.

Changes:

  1. Remove clear buttons from required settings: Add notClearable={true} to language and timezone selectors to prevent users from triggering invalid API calls
  2. Improve SimpleSelect visual feedback: Add dynamic chevron icon toggle (↓/↑) based on dropdown open/close state

Issue Fixed:

  • Users could click X buttons on required settings, causing "is not a valid language" errors
  • SimpleSelect chevron remained static (always ↓) regardless of dropdown state

Screenshots

Before After
X buttons visible on required settings, static down arrow No X buttons on required settings, dynamic up/down arrows

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23791 **State:** closed **Merged:** Yes --- > [\!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #23790`. Fixes #23790 ## Summary This PR fixes misleading clear buttons in language/timezone settings and improves SimpleSelect component UX. **Changes:** 1. **Remove clear buttons from required settings**: Add `notClearable={true}` to language and timezone selectors to prevent users from triggering invalid API calls 2. **Improve SimpleSelect visual feedback**: Add dynamic chevron icon toggle (↓/↑) based on dropdown open/close state **Issue Fixed:** - Users could click X buttons on required settings, causing "is not a valid language" errors - SimpleSelect chevron remained static (always ↓) regardless of dropdown state ## Screenshots | Before | After | |--------|-------| | X buttons visible on required settings, static down arrow | No X buttons on required settings, dynamic up/down arrows | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:25 -05:00
yindo closed this issue 2026-02-21 20:47:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?