langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23881] feat: Implements periodic deletion of workflow run logs that exceed t… #30430

New Issue
Closed
opened 2026-02-21 20:47:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23881

State: closed
Merged: Yes

…he retention period, with cascade deletion of all historical data associated with workflow_run.

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Close #23879

Main Features

  • Added new clean_workflow_runlogs_precise Celery task for automatic cleanup of expired workflow run logs
  • Supports configurable log retention days (WORKFLOW_LOG_RETENTION_DAYS) and batch processing size
  • Feature can be enabled/disabled via WORKFLOW_LOG_CLEANUP_ENABLED switch

Core Features

  • Complete cascade deletion: Deletes associated data in foreign key dependency order to ensure data consistency
  • Delete message-related tables (MessageFeedback, MessageFile, MessageAnnotation, etc.)
  • Delete workflow-related tables (WorkflowAppLog, WorkflowNodeExecutionModel)
  • Delete session variables and session records
    Finally delete the main WorkflowRun table

Robustness guarantees:

  • Batch processing to avoid memory overflow
  • Built-in retry mechanism (up to 3 retries)
  • Incremental delays on failure (5/10/15 minutes)
  • Transaction protection ensures atomic operations

Monitoring friendly: Provides detailed logging and execution time statistics

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23881 **State:** closed **Merged:** Yes --- …he retention period, with cascade deletion of all historical data associated with workflow_run. > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Close #23879 ### Main Features - Added new clean_workflow_runlogs_precise Celery task for automatic cleanup of expired workflow run logs - Supports configurable log retention days (WORKFLOW_LOG_RETENTION_DAYS) and batch processing size - Feature can be enabled/disabled via WORKFLOW_LOG_CLEANUP_ENABLED switch ### Core Features - Complete cascade deletion: Deletes associated data in foreign key dependency order to ensure data consistency - Delete message-related tables (MessageFeedback, MessageFile, MessageAnnotation, etc.) - Delete workflow-related tables (WorkflowAppLog, WorkflowNodeExecutionModel) - Delete session variables and session records Finally delete the main WorkflowRun table ### Robustness guarantees: - Batch processing to avoid memory overflow - Built-in retry mechanism (up to 3 retries) - Incremental delays on failure (5/10/15 minutes) - Transaction protection ensures atomic operations Monitoring friendly: Provides detailed logging and execution time statistics <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Checklist - [x] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:29 -05:00
yindo closed this issue 2026-02-21 20:47:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?