langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23880] fix: mime_type could be None #30431

New Issue
Closed
opened 2026-02-21 20:47:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:29 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23880

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Related https://github.com/langgenius/dify/pull/23127

This pull request improves the robustness of MIME type detection in the _get_remote_file_info function in api/factories/file_factory.py. The changes ensure that the function handles cases where the MIME type cannot be determined from the filename, and provides a fallback using the HTTP response headers.

Improvements to MIME type detection:

  • Ensured that mime_type is set to an empty string if it cannot be determined from the filename, preventing possible errors from None values.
  • Added a fallback to use the Content-Type header from the HTTP response if the MIME type is still empty after attempting to guess it from the filename.

Screenshots

Before After
... image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23880 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Related https://github.com/langgenius/dify/pull/23127 This pull request improves the robustness of MIME type detection in the `_get_remote_file_info` function in `api/factories/file_factory.py`. The changes ensure that the function handles cases where the MIME type cannot be determined from the filename, and provides a fallback using the HTTP response headers. Improvements to MIME type detection: * Ensured that `mime_type` is set to an empty string if it cannot be determined from the filename, preventing possible errors from `None` values. * Added a fallback to use the `Content-Type` header from the HTTP response if the MIME type is still empty after attempting to guess it from the filename. ## Screenshots | Before | After | |--------|-------| | ... | <img width="2156" height="1678" alt="image" src="https://github.com/user-attachments/assets/9d68b40a-690d-41de-81c9-7312be23e2e3" /> | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:29 -05:00
yindo closed this issue 2026-02-21 20:47:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?