langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #23943] refactor: unify pnpm version management with packageManager field #30451

New Issue
Closed
opened 2026-02-21 20:47:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:31 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/23943

State: closed
Merged: Yes

Fixes #23942

Summary

This PR unifies pnpm version management across all environments (development, CI, Docker) by implementing a single source of truth via the packageManager field in package.json.

Changes made:

  • Added packageManager: "pnpm@10.14.0" to web/package.json as the single source of truth
  • Updated Dockerfile to use corepack instead of hardcoded npm install -g pnpm@10.13.1
  • Removed hardcoded version: 10 from all GitHub Actions workflows (style.yml, web-tests.yml, translate-i18n-base-on-english.yml)

Benefits:

  • Eliminates version inconsistencies between environments
  • Reduces maintenance overhead when updating pnpm versions
  • Follows Node.js/npm standard practices with corepack
  • Single point of version management in package.json

All environments now automatically read the pnpm version from the packageManager field, ensuring consistency across development, CI, and production builds.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/23943 **State:** closed **Merged:** Yes --- Fixes #23942 ## Summary This PR unifies pnpm version management across all environments (development, CI, Docker) by implementing a single source of truth via the `packageManager` field in package.json. **Changes made:** - Added `packageManager: "pnpm@10.14.0"` to web/package.json as the single source of truth - Updated Dockerfile to use `corepack` instead of hardcoded `npm install -g pnpm@10.13.1` - Removed hardcoded `version: 10` from all GitHub Actions workflows (style.yml, web-tests.yml, translate-i18n-base-on-english.yml) **Benefits:** - Eliminates version inconsistencies between environments - Reduces maintenance overhead when updating pnpm versions - Follows Node.js/npm standard practices with corepack - Single point of version management in package.json All environments now automatically read the pnpm version from the packageManager field, ensuring consistency across development, CI, and production builds. ## Checklist - [x] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:47:31 -05:00
yindo closed this issue 2026-02-21 20:47:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?