langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24181] fix: initialize recur fields when switching to hourly frequency #30540

New Issue
Closed
opened 2026-02-21 20:47:41 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:41 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24181

State: closed
Merged: Yes

Problem

When switching from daily/weekly/monthly/once frequency to hourly frequency, the recur_every and recur_unit fields are not initialized in the visual config, causing validation to fail with "Invalid recur unit" error.

Root Cause: The handleFrequencyChange function only initializes the datetime field for hourly mode but ignores the required recur_every and recur_unit fields.

User Impact: Users cannot modify date/time after switching to hourly frequency until they manually click the minutes/hours toggle to initialize the missing field.

Solution

Initialize recur_every and recur_unit fields with safe defaults when switching to hourly frequency:

  • recur_every: Default to 1 (matches RecurConfig component default)
  • recur_unit: Default to 'hours' (matches RecurConfig component default)

Implementation:

...(frequency === 'hourly') && {
  recur_every: inputs.visual_config?.recur_every || 1,
  recur_unit: inputs.visual_config?.recur_unit || 'hours',
},

Backward Compatibility

  • Preserves existing values if already set (|| 1 and || 'hours' fallback)
  • Uses same defaults as UI components (RecurConfig)
  • Only affects hourly frequency mode
  • No impact on other frequency modes

Testing

  • Verified daily → hourly switch works correctly
  • Verified existing hourly configurations unchanged
  • Validated against existing validation rules (1-999 range, hours/minutes units)
**Original Pull Request:** https://github.com/langgenius/dify/pull/24181 **State:** closed **Merged:** Yes --- ## Problem When switching from daily/weekly/monthly/once frequency to hourly frequency, the `recur_every` and `recur_unit` fields are not initialized in the visual config, causing validation to fail with "Invalid recur unit" error. **Root Cause**: The `handleFrequencyChange` function only initializes the `datetime` field for hourly mode but ignores the required `recur_every` and `recur_unit` fields. **User Impact**: Users cannot modify date/time after switching to hourly frequency until they manually click the minutes/hours toggle to initialize the missing field. ## Solution Initialize `recur_every` and `recur_unit` fields with safe defaults when switching to hourly frequency: - `recur_every`: Default to `1` (matches RecurConfig component default) - `recur_unit`: Default to `'hours'` (matches RecurConfig component default) **Implementation**: ```typescript ...(frequency === 'hourly') && { recur_every: inputs.visual_config?.recur_every || 1, recur_unit: inputs.visual_config?.recur_unit || 'hours', }, ``` ## Backward Compatibility - Preserves existing values if already set (`|| 1` and `|| 'hours'` fallback) - Uses same defaults as UI components (RecurConfig) - Only affects hourly frequency mode - No impact on other frequency modes ## Testing - Verified daily → hourly switch works correctly - Verified existing hourly configurations unchanged - Validated against existing validation rules (1-999 range, hours/minutes units)
yindo added the pull-request label 2026-02-21 20:47:41 -05:00
yindo closed this issue 2026-02-21 20:47:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?