langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24357] Fix missing database commit in provider update handler #30592

New Issue
Closed
opened 2026-02-21 20:47:50 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:50 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24357

State: closed
Merged: Yes

Summary

  • Adds missing session.commit() call in the provider update handler
  • Ensures provider quota deductions are properly persisted to the database
  • Fixes issue where quota updates were prepared but lost when session ended

Related Issue

Fixes #24356

Testing

  • Verified that provider quota updates are now committed to the database
  • Tested message creation flow to ensure quotas are correctly deducted
  • Confirmed no regression in existing provider update functionality

Changes

  • Added session.commit() after provider updates in _execute_provider_updates() function
**Original Pull Request:** https://github.com/langgenius/dify/pull/24357 **State:** closed **Merged:** Yes --- ## Summary - Adds missing `session.commit()` call in the provider update handler - Ensures provider quota deductions are properly persisted to the database - Fixes issue where quota updates were prepared but lost when session ended ## Related Issue Fixes #24356 ## Testing - Verified that provider quota updates are now committed to the database - Tested message creation flow to ensure quotas are correctly deducted - Confirmed no regression in existing provider update functionality ## Changes - Added `session.commit()` after provider updates in `_execute_provider_updates()` function
yindo added the pull-request label 2026-02-21 20:47:50 -05:00
yindo closed this issue 2026-02-21 20:47:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?