langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24375] refactor: comprehensive schedule trigger system improvements #30603

New Issue
Closed
opened 2026-02-21 20:47:52 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:47:52 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24375

State: closed
Merged: No

Summary

This PR implements a comprehensive overhaul of the schedule trigger system, establishing a robust timezone-aware architecture with unified data flow and extensive test coverage.

Key Achievements

🏗️ Architecture Redesign

  • Single Source of Truth: Created unified TimezoneConverter middleware handling all timezone operations
  • UTC Storage Standard: Established UTC as storage format with user timezone for display
  • Eliminated Dual Systems: Removed old timezone-utils.ts and consolidated conversion logic

🐛 Critical Bug Fixes

  • Cron Timezone Issues: Fixed "30 11 * * *" showing 11:30 PM instead of AM
  • Past Time Filtering: Fixed "0 9 * * *" incorrectly showing today when time already passed
  • Monthly Date Bugs: Resolved UTC Date creation causing date offset issues (selecting 1st showing 31st)
  • Daily Time Comparison: Fixed timezone-aware scheduling for proper next-day execution

🧪 Test Infrastructure (210 tests, 94.38% coverage)

  • Cron Parser: Enhanced from 68.35% to 99.15% coverage (+30.8%)
  • Integration Tests: Added 309-line end-to-end timezone validation
  • Edge Case Testing: Comprehensive boundary condition and error handling tests
  • Performance Testing: Validated sub-100ms response times for complex expressions

🔧 Technical Improvements

  • Timezone-Aware Cron Parser: New parseCronExpressionWithTimezone() with proper user timezone handling
  • Enhanced DST Support: Improved daylight saving time handling using current date context
  • TypeScript Strict Mode: Full type safety with proper interface definitions
  • Error Resilience: Invalid timezone fallback to system timezone

Problem Resolution

✅ *"30 11 * * " displays correctly as 11:30 AM (not PM)
✅ Past cron times properly filtered based on user timezone
✅ Monthly frequency no longer shows wrong dates due to UTC offset
✅ Daily scheduling correctly determines next execution day
✅ Timezone picker maintains consistency during user interaction
✅ Node display shows accurate execution times

Files Changed

Added (3 files):

  • timezone-converter.ts - Unified timezone conversion middleware (300+ lines)
  • integration.test.ts - End-to-end timezone workflow validation (309 lines)
  • timezone-converter.test.ts - Comprehensive converter unit tests (475 lines)

Enhanced (5 files):

  • execution-time-calculator.ts - Added timezone-aware cron parsing (+100 lines)
  • cron-parser.spec.ts - Enhanced edge case testing (+124 lines)
  • use-config.ts - Integrated TimezoneConverter (-70 lines)
  • node.tsx - Added userProfile timezone parameter
  • execution-time-calculator.spec.ts - Fixed UTC test assertions

Removed (3 files):

  • timezone-utils.ts - Replaced by unified converter (-57 lines)
  • timezone-utils.spec.ts - Superseded by comprehensive tests (-105 lines)
  • use-config-timezone.test.ts - Merged into integration tests (-214 lines)

Impact

Code Quality: 94.38% test coverage, 210 passing tests, zero TypeScript errors
Performance: <100ms timezone conversions, optimized cron parsing
Maintainability: Single source of truth, unified patterns, comprehensive documentation
Reliability: Robust error handling, extensive edge case coverage, production-ready architecture

**Original Pull Request:** https://github.com/langgenius/dify/pull/24375 **State:** closed **Merged:** No --- ## Summary This PR implements a comprehensive overhaul of the schedule trigger system, establishing a robust timezone-aware architecture with unified data flow and extensive test coverage. ## Key Achievements ### 🏗️ Architecture Redesign - **Single Source of Truth**: Created unified `TimezoneConverter` middleware handling all timezone operations - **UTC Storage Standard**: Established UTC as storage format with user timezone for display - **Eliminated Dual Systems**: Removed old `timezone-utils.ts` and consolidated conversion logic ### 🐛 Critical Bug Fixes - **Cron Timezone Issues**: Fixed "30 11 * * *" showing 11:30 PM instead of AM - **Past Time Filtering**: Fixed "0 9 * * *" incorrectly showing today when time already passed - **Monthly Date Bugs**: Resolved UTC Date creation causing date offset issues (selecting 1st showing 31st) - **Daily Time Comparison**: Fixed timezone-aware scheduling for proper next-day execution ### 🧪 Test Infrastructure (210 tests, 94.38% coverage) - **Cron Parser**: Enhanced from 68.35% to 99.15% coverage (+30.8%) - **Integration Tests**: Added 309-line end-to-end timezone validation - **Edge Case Testing**: Comprehensive boundary condition and error handling tests - **Performance Testing**: Validated sub-100ms response times for complex expressions ### 🔧 Technical Improvements - **Timezone-Aware Cron Parser**: New `parseCronExpressionWithTimezone()` with proper user timezone handling - **Enhanced DST Support**: Improved daylight saving time handling using current date context - **TypeScript Strict Mode**: Full type safety with proper interface definitions - **Error Resilience**: Invalid timezone fallback to system timezone ## Problem Resolution ✅ **"30 11 * * *" displays correctly as 11:30 AM (not PM)** ✅ **Past cron times properly filtered based on user timezone** ✅ **Monthly frequency no longer shows wrong dates due to UTC offset** ✅ **Daily scheduling correctly determines next execution day** ✅ **Timezone picker maintains consistency during user interaction** ✅ **Node display shows accurate execution times** ## Files Changed **Added (3 files)**: - `timezone-converter.ts` - Unified timezone conversion middleware (300+ lines) - `integration.test.ts` - End-to-end timezone workflow validation (309 lines) - `timezone-converter.test.ts` - Comprehensive converter unit tests (475 lines) **Enhanced (5 files)**: - `execution-time-calculator.ts` - Added timezone-aware cron parsing (+100 lines) - `cron-parser.spec.ts` - Enhanced edge case testing (+124 lines) - `use-config.ts` - Integrated TimezoneConverter (-70 lines) - `node.tsx` - Added userProfile timezone parameter - `execution-time-calculator.spec.ts` - Fixed UTC test assertions **Removed (3 files)**: - `timezone-utils.ts` - Replaced by unified converter (-57 lines) - `timezone-utils.spec.ts` - Superseded by comprehensive tests (-105 lines) - `use-config-timezone.test.ts` - Merged into integration tests (-214 lines) ## Impact **Code Quality**: 94.38% test coverage, 210 passing tests, zero TypeScript errors **Performance**: <100ms timezone conversions, optimized cron parsing **Maintainability**: Single source of truth, unified patterns, comprehensive documentation **Reliability**: Robust error handling, extensive edge case coverage, production-ready architecture
yindo added the pull-request label 2026-02-21 20:47:52 -05:00
yindo closed this issue 2026-02-21 20:47:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?