langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24583] Refactor: replace count() > 0 check with exists() #30704

New Issue
Closed
opened 2026-02-21 20:48:04 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:04 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24583

State: closed
Merged: Yes

Fixes #24582

This PR refactors queries that check for the existence of a record from using count() > 0 to exists().
Considering cases where queries on Message use conversation_id, which is not a unique index, and queries on AppDatasetJoin rely solely on dataset_id, which cannot form a composite index, using EXISTS provides better performance than COUNT() since it avoids scanning the entire result set.

Changes

  • Replaced db.session.query(...).count() > 0 with db.session.scalar(select(exists().where(...))) in multiple places.
  • Updated to SQLAlchemy 2.0 style select + session.scalar instead of the legacy query API.

Advantages of using exists()

  • Performance: count() scans all matching rows to return the total count, which is unnecessary when we only need to know if any record exists.
  • Efficiency: exists() generates a SELECT EXISTS (SELECT 1 FROM ...) query. The database can short-circuit as soon as it finds the first matching row.
  • Clarity: The intent (check if record exists) is explicit and more readable than comparing a count with zero.
  • Modern API: Aligns code with SQLAlchemy 2.0 best practices (select / scalar).

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24583 **State:** closed **Merged:** Yes --- Fixes #24582 This PR refactors queries that check for the existence of a record from using `count() > 0` to `exists()`. Considering cases where queries on `Message` use `conversation_id`, which is not a unique index, and queries on `AppDatasetJoin` rely solely on `dataset_id`, which cannot form a composite index, using `EXISTS` provides better performance than `COUNT()` since it avoids scanning the entire result set. ### Changes - Replaced `db.session.query(...).count() > 0` with `db.session.scalar(select(exists().where(...)))` in multiple places. - Updated to SQLAlchemy 2.0 style `select + session.scalar` instead of the legacy `query` API. ### Advantages of using exists() - **Performance:** `count()` scans all matching rows to return the total count, which is unnecessary when we only need to know if any record exists. - **Efficiency:** `exists()` generates a `SELECT EXISTS (SELECT 1 FROM ...)` query. The database can short-circuit as soon as it finds the first matching row. - **Clarity:** The intent (check if record exists) is explicit and more readable than comparing a count with zero. - **Modern API:** Aligns code with SQLAlchemy 2.0 best practices (select / scalar). > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:04 -05:00
yindo closed this issue 2026-02-21 20:48:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?