langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24610] cleanup: remove temporary boolean test files from root directory #30714

New Issue
Closed
opened 2026-02-21 20:48:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:05 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24610

State: closed
Merged: Yes

Summary

Remove 5 temporary test files that were left in the project root directory after PR #24437.

Files Removed

  • simple_boolean_test.py
  • test_boolean_conditions.py
  • test_boolean_contains_fix.py
  • test_boolean_factory.py
  • test_boolean_variable_assigner.py

Rationale

These were temporary development test files used during boolean type implementation. The functionality is now properly tested in the formal test suite:

  • Boolean conditions: api/tests/unit_tests/core/workflow/nodes/test_if_else.py (9 tests passing)
  • Boolean segments: api/tests/unit_tests/factories/test_variable_factory.py
  • Boolean validation: api/tests/unit_tests/core/variables/test_segment_type_validation.py

The temporary files:

  • Had quality issues (one test was failing)
  • Were not in pytest format
  • Used development hacks like sys.path.insert(0, ...)
  • Don't belong in the project root directory

Testing

Verified that formal boolean tests are comprehensive and passing:

uv run --project api pytest api/tests/unit_tests/core/workflow/nodes/test_if_else.py -k "boolean" -v
# Result: 9 passed, 3 deselected, 18 warnings

Closes #24609

**Original Pull Request:** https://github.com/langgenius/dify/pull/24610 **State:** closed **Merged:** Yes --- ## Summary Remove 5 temporary test files that were left in the project root directory after PR #24437. ## Files Removed - `simple_boolean_test.py` - `test_boolean_conditions.py` - `test_boolean_contains_fix.py` - `test_boolean_factory.py` - `test_boolean_variable_assigner.py` ## Rationale These were temporary development test files used during boolean type implementation. The functionality is now properly tested in the formal test suite: - **Boolean conditions**: `api/tests/unit_tests/core/workflow/nodes/test_if_else.py` (9 tests passing) - **Boolean segments**: `api/tests/unit_tests/factories/test_variable_factory.py` - **Boolean validation**: `api/tests/unit_tests/core/variables/test_segment_type_validation.py` The temporary files: - Had quality issues (one test was failing) - Were not in pytest format - Used development hacks like `sys.path.insert(0, ...)` - Don't belong in the project root directory ## Testing Verified that formal boolean tests are comprehensive and passing: ```bash uv run --project api pytest api/tests/unit_tests/core/workflow/nodes/test_if_else.py -k "boolean" -v # Result: 9 passed, 3 deselected, 18 warnings ``` Closes #24609
yindo added the pull-request label 2026-02-21 20:48:05 -05:00
yindo closed this issue 2026-02-21 20:48:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30714
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?