langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-24 22:11:36 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24636] Fix: Parameter Extractor Uses Correct Prompt for Prompt Mode in Chat Models #30723

New Issue
Closed
opened 2026-02-21 20:48:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:06 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24636

State: closed
Merged: Yes

Fixes #24629

Summary

The Parameter Extractor node had a critical bug where it incorrectly used FUNCTION_CALLING_EXTRACTOR_SYSTEM_PROMPT even when users explicitly selected "Prompt" mode instead of "Function Call" mode.

Changes:

Files Modified:

  • api/core/workflow/nodes/parameter_extractor/parameter_extractor_node.py

Changes Made:

  1. Added Missing Import: Added CHAT_GENERATE_JSON_PROMPT to the imports from .prompts (previously missing)
  2. Fixed Prompt Selection Logic: Updated _get_prompt_engineering_prompt_template() method to use the correct prompt.

Screenshots

N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24636 **State:** closed **Merged:** Yes --- Fixes #24629 ## Summary The Parameter Extractor node had a critical bug where it incorrectly used FUNCTION_CALLING_EXTRACTOR_SYSTEM_PROMPT even when users explicitly selected "Prompt" mode instead of "Function Call" mode. ### Changes: Files Modified: - api/core/workflow/nodes/parameter_extractor/parameter_extractor_node.py Changes Made: 1. Added Missing Import: Added CHAT_GENERATE_JSON_PROMPT to the imports from .prompts (previously missing) 2. Fixed Prompt Selection Logic: Updated _get_prompt_engineering_prompt_template() method to use the correct prompt. ## Screenshots N/A ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:06 -05:00
yindo closed this issue 2026-02-21 20:48:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30723
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?