langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24674] fix: workflow_finish_to_stream_response assert exception with celery … #30744

New Issue
Closed
opened 2026-02-21 20:48:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24674

State: closed
Merged: Yes

Summary

fix: https://github.com/langgenius/dify/pull/20050#issuecomment-3190585010

@laipz8200 I'm back with some feedback 🤦🏻‍♀️

Using the celery repository we occasionally get assert exception here:

    def workflow_finish_to_stream_response(
        self,
        *,
        session: Session,
        task_id: str,
        workflow_execution: WorkflowExecution,
    ) -> WorkflowFinishStreamResponse:
        created_by = None
        workflow_run = session.scalar(select(WorkflowRun).where(WorkflowRun.id == workflow_execution.id_))
        **assert workflow_run is not None**

My guess is that as the writing of WorkflowRun is asynchronous, reading from DB at the end of the api session cannot be guaranteed. If that's true, should we modify this method to fit this situation?

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24674 **State:** closed **Merged:** Yes --- ## Summary fix: https://github.com/langgenius/dify/pull/20050#issuecomment-3190585010 > @laipz8200 I'm back with some feedback 🤦🏻‍♀️ > > Using the celery repository we occasionally get assert exception here: > > ``` > def workflow_finish_to_stream_response( > self, > *, > session: Session, > task_id: str, > workflow_execution: WorkflowExecution, > ) -> WorkflowFinishStreamResponse: > created_by = None > workflow_run = session.scalar(select(WorkflowRun).where(WorkflowRun.id == workflow_execution.id_)) > **assert workflow_run is not None** > ``` > > My guess is that as the writing of WorkflowRun is asynchronous, reading from DB at the end of the api session cannot be guaranteed. If that's true, should we modify this method to fit this situation? ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:08 -05:00
yindo closed this issue 2026-02-21 20:48:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?