langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 09:10:05 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24815] fix: Fix database connection leak in EasyUIBasedGenerateTaskPipeline #30803

New Issue
Closed
opened 2026-02-21 20:48:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:15 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24815

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR fixes a database connection leak issue in the EasyUIBasedGenerateTaskPipeline class.

Problem

The _agent_thought_to_stream_response method was using the global db.session for database queries, while other methods in the same file use with Session(db.engine) as session: context managers. The db.session approach doesn't automatically close database connections, leading to connection leaks.

Solution

Replace the db.session.query() call with an explicit Session(db.engine) context manager to ensure database connections are properly closed after use.

Changes

  • Modified the database query approach in _agent_thought_to_stream_response method
  • Changed from db.session.query() to with Session(db.engine) as session:
  • Ensured database connections are automatically closed after use to prevent leaks

Impact

This fix resolves potential database connection leaks, improves application stability in high-concurrency scenarios, and reduces pressure on the database connection pool.

Screenshots

Before After
image
...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24815 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR fixes a database connection leak issue in the `EasyUIBasedGenerateTaskPipeline` class. ### Problem The `_agent_thought_to_stream_response` method was using the global `db.session` for database queries, while other methods in the same file use `with Session(db.engine) as session:` context managers. The `db.session` approach doesn't automatically close database connections, leading to connection leaks. ### Solution Replace the `db.session.query()` call with an explicit `Session(db.engine)` context manager to ensure database connections are properly closed after use. ### Changes - Modified the database query approach in `_agent_thought_to_stream_response` method - Changed from `db.session.query()` to `with Session(db.engine) as session:` - Ensured database connections are automatically closed after use to prevent leaks ### Impact This fix resolves potential database connection leaks, improves application stability in high-concurrency scenarios, and reduces pressure on the database connection pool. ## Screenshots | Before | After | |--------|-------| | <img width="5018" height="544" alt="image" src="https://github.com/user-attachments/assets/0cdcd74e-9aca-4d4b-a6ad-9291ccb1de88" /> | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:15 -05:00
yindo closed this issue 2026-02-21 20:48:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?