langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24825] feat: add AppTrigger status validation for webhook execution #30810

New Issue
Closed
opened 2026-02-21 20:48:16 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:16 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24825

State: closed
Merged: No

Summary

  • Add AppTrigger status validation before webhook execution
  • Check if trigger is enabled/disabled in AppTrigger model
  • Prevent disabled triggers from executing workflows

Changes

  • Updated WebhookService.get_webhook_trigger_and_workflow() to query AppTrigger model
  • Added status validation to ensure only enabled triggers can execute
  • Import AppTrigger, AppTriggerStatus, AppTriggerType from models.workflow

Test plan

  • Verify webhook execution fails when AppTrigger status is disabled
  • Verify webhook execution succeeds when AppTrigger status is enabled
  • Verify appropriate error messages are returned for disabled triggers

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/langgenius/dify/pull/24825 **State:** closed **Merged:** No --- ## Summary - Add AppTrigger status validation before webhook execution - Check if trigger is enabled/disabled in AppTrigger model - Prevent disabled triggers from executing workflows ## Changes - Updated `WebhookService.get_webhook_trigger_and_workflow()` to query AppTrigger model - Added status validation to ensure only enabled triggers can execute - Import AppTrigger, AppTriggerStatus, AppTriggerType from models.workflow ## Test plan - [x] Verify webhook execution fails when AppTrigger status is disabled - [x] Verify webhook execution succeeds when AppTrigger status is enabled - [x] Verify appropriate error messages are returned for disabled triggers 🤖 Generated with [Claude Code](https://claude.ai/code)
yindo added the pull-request label 2026-02-21 20:48:16 -05:00
yindo closed this issue 2026-02-21 20:48:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30810
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?