langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24956] refactor: update radio component to handle boolean values instead of numeric #30865

New Issue
Closed
opened 2026-02-21 20:48:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:22 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24956

State: closed
Merged: Yes

Fixes https://github.com/langgenius/dify/issues/24964

Summary

This pull request refactors how boolean values are handled in radio button components across the codebase, improving type safety and consistency. The main change is switching from using 1/0 (numbers) to true/false (booleans) for representing boolean values in radio groups and related handlers.

Boolean Value Handling Improvements

  • Updated all radio button components (Radio.Group and Radio) to use true/false instead of 1/0 for boolean fields, ensuring consistent and type-safe handling of boolean values in forms.
  • Removed unnecessary conversion logic (such as booleanRadioValue and value mapping) that previously mapped boolean values to numbers, simplifying the code.

Type Definitions

  • Extended the value prop type for Radio.Group and Radio components to include boolean, making the components compatible with the new boolean value handling.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24956 **State:** closed **Merged:** Yes --- Fixes https://github.com/langgenius/dify/issues/24964 ## Summary This pull request refactors how boolean values are handled in radio button components across the codebase, improving type safety and consistency. The main change is switching from using `1`/`0` (numbers) to `true`/`false` (booleans) for representing boolean values in radio groups and related handlers. ### Boolean Value Handling Improvements * Updated all radio button components (`Radio.Group` and `Radio`) to use `true`/`false` instead of `1`/`0` for boolean fields, ensuring consistent and type-safe handling of boolean values in forms. * Removed unnecessary conversion logic (such as `booleanRadioValue` and value mapping) that previously mapped boolean values to numbers, simplifying the code. ### Type Definitions * Extended the `value` prop type for `Radio.Group` and `Radio` components to include `boolean`, making the components compatible with the new boolean value handling. ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:22 -05:00
yindo closed this issue 2026-02-21 20:48:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?