langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #24984] fix: ensure the modal closed by level #30872

New Issue
Closed
opened 2026-02-21 20:48:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:23 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/24984

State: closed
Merged: Yes

Fixes #24983

Summary

This pull request adds an enhancement to the ModelModal component to improve user experience. The most notable change is the addition of keyboard support for closing the modal using the Escape key.

User experience improvements:

  • Added a useEffect hook to ModelModal that listens for the Escape key and triggers the onCancel callback, allowing users to close the modal with the keyboard.
  • Imported useEffect from React to support the new keyboard event listener logic.

Screenshots

Before After
Image CleanShot 2025-09-02 at 16 29 38

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/24984 **State:** closed **Merged:** Yes --- Fixes #24983 ## Summary This pull request adds an enhancement to the `ModelModal` component to improve user experience. The most notable change is the addition of keyboard support for closing the modal using the Escape key. **User experience improvements:** * Added a `useEffect` hook to `ModelModal` that listens for the Escape key and triggers the `onCancel` callback, allowing users to close the modal with the keyboard. * Imported `useEffect` from React to support the new keyboard event listener logic. ## Screenshots | Before | After | |--------|-------| | ![Image](https://github.com/user-attachments/assets/564706fc-1fc9-49b6-9529-a0b5eebafa49) | ![CleanShot 2025-09-02 at 16 29 38](https://github.com/user-attachments/assets/83c5570c-2a31-4fbf-96ad-526ef032c76f)| ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:23 -05:00
yindo closed this issue 2026-02-21 20:48:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?