langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25003] fix: prevent workflow canvas clearing due to race condition and viewport errors #30884

New Issue
Closed
opened 2026-02-21 20:48:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25003

State: closed
Merged: Yes

Changes

Fixed race condition issues that caused workflow canvas to clear after publishing and refreshing:

Modified Files:

  1. use-nodes-sync-draft.ts: Added initialization state detection to prevent syncing empty workflow data
  2. use-workflow-interactions.ts: Added viewport validation to prevent undefined property access errors
  3. use-workflow-refresh-draft.ts: Ensured complete data structure with default viewport values

Problem Solved:

  • Prevents canvas clearing after publish + refresh
  • Fixes 'Cannot read properties of undefined (reading x)' viewport errors
  • Reduces 400 HTTP errors from invalid sync requests

All changes are backward compatible with defensive programming approach.

**Original Pull Request:** https://github.com/langgenius/dify/pull/25003 **State:** closed **Merged:** Yes --- ## Changes Fixed race condition issues that caused workflow canvas to clear after publishing and refreshing: ### Modified Files: 1. **use-nodes-sync-draft.ts**: Added initialization state detection to prevent syncing empty workflow data 2. **use-workflow-interactions.ts**: Added viewport validation to prevent undefined property access errors 3. **use-workflow-refresh-draft.ts**: Ensured complete data structure with default viewport values ### Problem Solved: - Prevents canvas clearing after publish + refresh - Fixes 'Cannot read properties of undefined (reading x)' viewport errors - Reduces 400 HTTP errors from invalid sync requests All changes are backward compatible with defensive programming approach.
yindo added the pull-request label 2026-02-21 20:48:25 -05:00
yindo closed this issue 2026-02-21 20:48:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30884
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?