langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25018] refactor: remove unused is_deleted field from conversations table #30889

New Issue
Open
opened 2026-02-21 20:48:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25018

State: open
Merged: No

Summary

  • Removed the is_deleted field from the Conversation model that was never utilized
  • Cleaned up all references to is_deleted filtering in conversation queries
  • Added database migration to drop the unused column

Related Issue

Fixes #25017

Test plan

  • Run existing tests to ensure no regressions
  • Verify conversation listing and filtering still works correctly
  • Test database migration rollback and upgrade
**Original Pull Request:** https://github.com/langgenius/dify/pull/25018 **State:** open **Merged:** No --- ## Summary - Removed the `is_deleted` field from the Conversation model that was never utilized - Cleaned up all references to `is_deleted` filtering in conversation queries - Added database migration to drop the unused column ## Related Issue Fixes #25017 ## Test plan - [x] Run existing tests to ensure no regressions - [x] Verify conversation listing and filtering still works correctly - [x] Test database migration rollback and upgrade
yindo added the pull-request label 2026-02-21 20:48:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?