langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25021] chore: remove ty type checker from reformat script and pre-commit hooks #30890

New Issue
Closed
opened 2026-02-21 20:48:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:25 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25021

State: closed
Merged: Yes

Summary

  • Remove ty type checker from dev/reformat script
  • Remove ty type checker from web/.husky/pre-commit hook
  • Keep mypy for critical type safety checks

Motivation

The ty type checker is currently blocking developers from committing code in the early stages of this project. Since the project is not yet production-ready and may contain code that isn't fully covered by type annotations, enforcing strict type checking at the pre-commit stage creates a poor developer experience.

By removing ty from the automated checks while keeping mypy, we maintain type safety where it matters most while allowing more flexibility during the development phase.

Fixes #25020

**Original Pull Request:** https://github.com/langgenius/dify/pull/25021 **State:** closed **Merged:** Yes --- ## Summary - Remove ty type checker from `dev/reformat` script - Remove ty type checker from `web/.husky/pre-commit` hook - Keep mypy for critical type safety checks ## Motivation The ty type checker is currently blocking developers from committing code in the early stages of this project. Since the project is not yet production-ready and may contain code that isn't fully covered by type annotations, enforcing strict type checking at the pre-commit stage creates a poor developer experience. By removing ty from the automated checks while keeping mypy, we maintain type safety where it matters most while allowing more flexibility during the development phase. Fixes #25020
yindo added the pull-request label 2026-02-21 20:48:25 -05:00
yindo closed this issue 2026-02-21 20:48:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30890
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?