langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25059] fix: missing key for translation path #30912

New Issue
Closed
opened 2026-02-21 20:48:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25059

State: closed
Merged: Yes

Summary

This PR addresses several translation and internationalization issues in the workflow trigger system:

Key Fixes:

  1. Missing validation translations - Added missing webhookUrlRequired and invalidParameterType translation keys that were causing display issues
  2. Incorrect translation paths - Fixed wrong translation key paths from workflow.nodes.webhook to workflow.nodes.triggerWebhook
  3. Block selector improvements - Enhanced tooltip display for webhook trigger to show 'Custom Webhook' while maintaining 'Webhook Trigger' in selection list
  4. Translation consistency - Unified start block translations across languages to properly reflect 'User Input' meaning

Technical Approach:

  • Used minimal code changes with conditional logic instead of creating redundant translation structures
  • Maintained existing architecture (TriggerPlugin continues using dedicated selector)
  • Applied consistent translation patterns across EN/ZH/JP languages

The changes ensure proper internationalization of workflow trigger validation messages and improve user experience with clearer, consistent naming.

Screenshots

Before After
image image
image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/25059 **State:** closed **Merged:** Yes --- ## Summary This PR addresses several translation and internationalization issues in the workflow trigger system: **Key Fixes:** 1. **Missing validation translations** - Added missing webhookUrlRequired and invalidParameterType translation keys that were causing display issues 2. **Incorrect translation paths** - Fixed wrong translation key paths from workflow.nodes.webhook to workflow.nodes.triggerWebhook 3. **Block selector improvements** - Enhanced tooltip display for webhook trigger to show 'Custom Webhook' while maintaining 'Webhook Trigger' in selection list 4. **Translation consistency** - Unified start block translations across languages to properly reflect 'User Input' meaning **Technical Approach:** - Used minimal code changes with conditional logic instead of creating redundant translation structures - Maintained existing architecture (TriggerPlugin continues using dedicated selector) - Applied consistent translation patterns across EN/ZH/JP languages The changes ensure proper internationalization of workflow trigger validation messages and improve user experience with clearer, consistent naming. ## Screenshots | Before | After | |--------|-------| |<img width="429" height="183" alt="image" src="https://github.com/user-attachments/assets/f60a52c0-49c1-43f4-a3de-ca326d44e330" />|<img width="425" height="159" alt="image" src="https://github.com/user-attachments/assets/072a855e-d14e-458a-81ed-c7966eac286c" />| | |<img width="239" height="159" alt="image" src="https://github.com/user-attachments/assets/097086a8-e360-424b-b87d-b2671e05ac89" />| ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:28 -05:00
yindo closed this issue 2026-02-21 20:48:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?