langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25268] fix: resolve typing errors in configs module #30987

New Issue
Closed
opened 2026-02-21 20:48:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:36 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25268

State: closed
Merged: Yes

Summary

Fixes typing errors throughout the configs module to improve type safety and code quality.

Related Issues

Fixes #25267

Changes

Middleware Configuration

  • Fixed inheritance issue in MiddlewareConfig by removing duplicate DatabaseConfig inheritance
  • Changed ClickzettaConfig and MatrixoneConfig from BaseModel to BaseSettings for proper Pydantic configuration

Remote Settings Sources

  • Added comprehensive type hints to Apollo client and utilities
  • Added type annotations to Nacos HTTP client and utilities
  • Fixed function signatures and return types throughout

Project Configuration

  • Updated pyrightconfig.json to enable type checking for the configs directory
  • Fixed import issues in packaging module

Notes

All changes maintain backward compatibility while improving type safety.

**Original Pull Request:** https://github.com/langgenius/dify/pull/25268 **State:** closed **Merged:** Yes --- ## Summary Fixes typing errors throughout the configs module to improve type safety and code quality. ## Related Issues Fixes #25267 ## Changes ### Middleware Configuration - Fixed inheritance issue in MiddlewareConfig by removing duplicate DatabaseConfig inheritance - Changed ClickzettaConfig and MatrixoneConfig from BaseModel to BaseSettings for proper Pydantic configuration ### Remote Settings Sources - Added comprehensive type hints to Apollo client and utilities - Added type annotations to Nacos HTTP client and utilities - Fixed function signatures and return types throughout ### Project Configuration - Updated pyrightconfig.json to enable type checking for the configs directory - Fixed import issues in packaging module ## Notes All changes maintain backward compatibility while improving type safety.
yindo added the pull-request label 2026-02-21 20:48:36 -05:00
yindo closed this issue 2026-02-21 20:48:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30987
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?